Math-magicians Milestone 5: Full website #6
Conversation
There was a problem hiding this comment.
Hi @andres-condezo 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider the inline comment I made for optional changes
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| const NavLink2 = () => { | ||
| const title = 'NavLink'; | ||
|
|
||
| return ( | ||
| <h1>{title}</h1> | ||
| ); | ||
| }; | ||
|
|
||
| export default NavLink2; |
There was a problem hiding this comment.
- (Optional) It would be nice to delete this file because it doesn't serve any purpose. Removing such files satisfies the YAGNI (You are Gonna Need It) principle.
There was a problem hiding this comment.
Hi @Gambit142 👋
Thank you for your feedback, I forgot to delete that test file, I'll delete it right now 👍 .
Math-magicians Milestone 5: Full website
Hi there 👋
Thanks for taking the time to review my project.
Changes
In this milestone:
Get Started
Visit live demo :
• Math Magician Live Demo Link
or:
Clone the repository :
•
$ git clone https://github.com/andres-condezo/math-magicians.git•
$ cd math-magicians•
$ git checkout full-website•
$ npm install•
$ npm startAny comment or suggestion will be thankfully received.