Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status.sh - Repack everything into functions #24

Closed
andresgongora opened this issue May 24, 2019 · 2 comments
Closed

status.sh - Repack everything into functions #24

andresgongora opened this issue May 24, 2019 · 2 comments

Comments

@andresgongora
Copy link
Owner

All variables that are displayed should be "provided" by a function with the appropriate name, instead of being stored in variables.

That way, we can easily add extra functionality in a modular and salable fashion. For example, a function called getExternalIP might do several checks to find the best tool to get the IP instead of resorting only to dig or wget (as suggested by @olmari ).

This also helps with #20

@andresgongora
Copy link
Owner Author

First half done - As this is modular, it can be done in incremental steps

@andresgongora
Copy link
Owner Author

Solved in #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant