Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GUI redirects me to invalid url #65

Closed
mtzirkel opened this issue Oct 25, 2022 · 6 comments
Closed

[BUG] GUI redirects me to invalid url #65

mtzirkel opened this issue Oct 25, 2022 · 6 comments

Comments

@mtzirkel
Copy link

Describe your context
I am trying to host my dash app on render. I can go through the gui checklist but when I hip deploy to render it redirects me to render and I see the following message
image

  • replace the result of dash-tools --version below
dashtools 1.10.1

  • please tell us what operating system you are using
linux POPos

Describe the bug

It seems to me that there is some path concatenation that is not working correctly and in quickly scanning your repository I believe that on line 27 of deployPage.py is where this is occurring.
When looking at my github i see that dashtools is successfully pushing to my github repo(DashTool Automatic Push - 10/25/2022 @ 9:01:44)

I created a pull request that might work. Not sure what else uses that function though

Expected behavior

I expect it to push to render

Thanks for your work this is a great repo

@andrew-hossack
Copy link
Owner

Hey @mtzirkel, for some reason I'm not seeing that issue on my laptop. What steps did you take to init and add your Git repo?

@andrew-hossack andrew-hossack pinned this issue Oct 26, 2022
@mtzirkel
Copy link
Author

Initially i was using Pycharm's version control tool but I was able to recreate it using the gihub CLI in another repository. Both have the same issue of redirecting me to https://github.com///github.com/mtzirkel/dashtemp. I was able to use the yaml file and requirements.txt and get it on render earlier following their setup instructions. For what it is worth.

@andrew-hossack
Copy link
Owner

andrew-hossack commented Oct 26, 2022

Strange, I will test this more and release a patch soon. Would you mind running the following command in the application you have pushed to github and sharing the output?

git config --get remote.origin.url

It should read something like git@github.com:andrew-hossack/testrepo2.git but I'm thinking yours might be different

@andrew-hossack
Copy link
Owner

I'm pretty sure I know what the bug is. Only SSH keys for remote origins are supported right now, eg. if you added your remote origin via HTTP it won't work. Let me push out a new update to address this.

@andrew-hossack
Copy link
Owner

I opened #67, feel free to review!

@andrew-hossack
Copy link
Owner

I pushed out the fix to Version 1.10.2, so go ahead and run

python -m pip install --upgrade dash-tools

and try again. Let me know if you still run into issues.

@andrew-hossack andrew-hossack unpinned this issue Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants