Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for gatsby v3 #144

Closed
codepunkt opened this issue Mar 5, 2021 · 11 comments
Closed

Update for gatsby v3 #144

codepunkt opened this issue Mar 5, 2021 · 11 comments
Labels
help wanted Would love a PR

Comments

@codepunkt
Copy link
Contributor

image

@zero-plusplus
Copy link

I am using machine translation.

To support gatsby v3, simply change the peerDependencies in package.json to "^3.0.0".

https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v2-to-v3/#for-plugin-maintainers

@kremalicious
Copy link

kremalicious commented Mar 14, 2021

There might be more updates required to make this plugin fully work with Gatsby v3. I am running into this issue locally with Gatsby v3.0.4 & gatsby-remark-vscode v3.2.0:

When running local dev server, after saving for the second or third time, the dev server just hangs with:

Missing onError handler for invocation 'building-schema', error was 'Error: Schema must contain
uniquely named types but contains multiple types named "GRVSCStylesheet".'. Stacktrace was 'Error:
 Schema must contain uniquely named types but contains multiple types named "GRVSCStylesheet".

This has also been reported over on gatsby repo gatsbyjs/gatsby#30199

I am able to reproduce this in a minimal test case with gatsby-starter-blog + gatsby-remark-vscode + gatsby-source-graphql https://github.com/kremalicious/gatsby-test-case-30199

@andrewbranch
Copy link
Owner

Interesting find @kremalicious. I had observed earlier that multiple type declarations seemed to merge, which was really useful. I guess that’s not allowed anymore, which is a shame.

@kremalicious
Copy link

seems to have been addressed in upstream gatsby for all similar use cases, pending new Gatsby release gatsbyjs/gatsby#30318

@andrewbranch
Copy link
Owner

Great! This is why I don’t fix bugs too fast 😂

In seriousness, I’m not sure when I’ll have time to get to the rest of this issue, but if someone wants to open a PR updating the peer dep and making sure everything works, I will make the time to review it.

@tnorlund
Copy link
Contributor

I just upgraded to Gatsby 3.0.1, and I'd like to install this package. When I attempt to, Get the error that the peer dependency is for Gatsby v 2.12.1. Is this still an issue?

@tnorlund
Copy link
Contributor

I would really like to help out with this. I have a PR, but I'm not sure how you are handling the Jest testing. The GraphQL queries are off. If I could get the testing working, I'm sure I could increment the packages required for Gatsby V3.

@tnorlund
Copy link
Contributor

How do I NPM install this to my Gatsby site?

@andrewbranch
Copy link
Owner

Released as v3.2.1. Thanks @tnorlund!

@yehezkiell
Copy link

is this already fixed? could not use gatsby-remark-vscode with gatsby version 4.5.4 @andrewbranch

@andrewbranch
Copy link
Owner

#174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Would love a PR
Projects
None yet
Development

No branches or pull requests

6 participants