Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up text formatting #30

Closed
andrewcmyers opened this issue Feb 16, 2021 · 1 comment
Closed

Speed up text formatting #30

andrewcmyers opened this issue Feb 16, 2021 · 1 comment

Comments

@andrewcmyers
Copy link
Owner

andrewcmyers commented Feb 16, 2021 •
edited

It's a little slow. Part of the reason seems to be my use of 'unshift' and 'slice'. Options for fixing are to reverse the order of the arrays being used so I can do 'push', or to switch to linked lists. Not clear that reversing the order solves the 'slice' part.
andrewcmyers referenced this issue Feb 16, 2021
@andrewcmyers
Reverse arrays so we can use O(1) push instead of O(n) unshift.
fc6b3f7 
A slice() remains to be removed.
andrewcmyers referenced this issue Feb 16, 2021
@andrewcmyers
Figured out an easy way to get most of the benefit of
ce60f77 
nondestructive lists while still using an array, speedup
up text formatting a bit.
@andrewcmyers
Copy link
Owner Author

good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewcmyers