-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong Floating number regex #31
Comments
@oxinabox - could you add me as a collaborator on this repo so I can add a PR to fix this? |
no, but you are welcome to make a pull request. |
I can't make a branch in the repo to make a PR because I don't have permission. Do you really want me to fork it and make a PR from my own repo? I'm not asking for permissions to actually merge anything. |
Yes. That is exactly what i want. |
Okay, you can close this now btw. |
The current implementation
is missing the optional sign for the exponent:
"-?(\d*\.?\d+|\d+\.\d*)([eE]-?\d+)?"
An implementation of PFloat16 is also missing.
The text was updated successfully, but these errors were encountered: