Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Floating number regex #31

Closed
guyvdbroeck opened this issue Jun 24, 2019 · 5 comments
Closed

Wrong Floating number regex #31

guyvdbroeck opened this issue Jun 24, 2019 · 5 comments

Comments

@guyvdbroeck
Copy link

guyvdbroeck commented Jun 24, 2019

The current implementation

PFloat64() = Parse(p"-?(\d*\.?\d+|\d+\.\d*)([eE]\d+)?", Float64)

is missing the optional sign for the exponent: "-?(\d*\.?\d+|\d+\.\d*)([eE]-?\d+)?"
An implementation of PFloat16 is also missing.

@richardreeve
Copy link
Contributor

@oxinabox - could you add me as a collaborator on this repo so I can add a PR to fix this?

@oxinabox
Copy link
Collaborator

no, but you are welcome to make a pull request.

@richardreeve
Copy link
Contributor

I can't make a branch in the repo to make a PR because I don't have permission. Do you really want me to fork it and make a PR from my own repo? I'm not asking for permissions to actually merge anything.

@oxinabox
Copy link
Collaborator

oxinabox commented Oct 26, 2023

Do you really want me to fork it and make a PR from my own repo?

Yes. That is exactly what i want.

@richardreeve
Copy link
Contributor

Okay, you can close this now btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants