Add .NET 3.5 Backwards Compatibility #191

kamranayub · 2012-02-26T18:49:57Z

Pull Request for Issue #168

Goals

As much shim transparency as possible to not disrupt existing codebase
Totally automated multi-targeted build process
No extra Nuget packages
As little extra configuration as possible for end-users (this will be eliminated in Nuget 1.8 hopefully)
Least maintenance headache as possible (the only annoying thing will be updating Cassette's own nuget dependencies)

Rundown

Added Cassette.FX35.sln for easy 3.5 development
Added shims where needed to add support for .NET 3.5, redirects or uses .NET 4 native methods in 4.0 mode (uses NET40 and NET35 constants)
Modified csproj files to conditionally reference/include files based on TargetFrameworkVersion
Added contribution documentation to help contributors code against 3.5
Cassette, Web, Views, UnitTests, and IntegrationTests all have .NET 3.5 configurations (Debug-FX35, Release-FX35)
Updated build.xml to support multi-targeting
Updated Nuget package workflow using XDT transformations (less maintenance)
Added DotNet35 example web project
Added documentation to Cassette website under Getting Started
Removed WebActivator in favor of CassetteHttpModule starting/stopping Cassette (@andrewdavey's suggestion to avoid a new Nuget package)

Potential Issues

Will the HttpModule be as good as WebActivator? Remains to be seen. In Nuget 1.8 (hopefully) we can reintroduce the dependency for .NET 4 and use this method for 3.5 (that will also remove any extra configuration for end-users).
CoffeeScript compilation is using old multi-threaded method

Conflicts: src/Cassette/CassetteApplicationContainerFactoryBase.cs

…includes in csproj file for Cassette project to support multi-targeting.

…festWriter

…e packages

…into dotnet-35

Added a new page to website documentation for how to configure Cassette in .NET 3.5

Changed how Nuget packaging works to support multiple framework targeting. Updated Fx35 docs with a gotcha I ran into during testing.

…orkaround in IsolatedStorageFile and opted to throw NotImplementedException instead for LastWriteTime

…uild to 3.5 as well. All tests pass and everything is green. Nuget packages are ackaged correctly based on local feed test. This is a fully stable (and working) commit!

…); Fixed Cassette nuspecs to use Pandora.dll from lib35/lib40 folder.

…; fix NET40 constant not being in Views or Web

…in 4.0 mode; fix OpenFile extension method

…ence for other peeps

kamranayub · 2012-02-26T19:10:11Z

src/Cassette/IO/IsolatedStorageDirectory.cs

@@ -66,7 +66,7 @@ public IEnumerable<IFile> GetFiles(string searchPattern, SearchOption searchOpti
            var storage = getStorage();
            return storage.GetFileNames(searchPattern).Select(
                filename => new IsolatedStorageFile(GetAbsolutePath(filename), getStorage, this)
-            );
+                       ).Cast<IFile>();


Another variance thing for 3.5

andrewdavey · 2012-02-26T20:34:11Z

This is amazing! I've only had time for a quick scan of the commits, but it's looking great.

I've just released 1.1.0. I'll do a full review of this pull request and aim to get it merged in for the next release. I'm away most of next week and following weekend, so this may take a little while. It's top of my Cassette to-do list though :)

I'll add more inline comments as I'm reviewing. Thanks again!

kamranayub · 2012-02-26T20:45:15Z

No problem! I'm glad to be of service. Just let me know if there things I should add/remove and I'll commit them.

…bility

kamranayub · 2012-02-26T21:11:36Z

Merged in your latest v1.1 changes :)

kamranayub · 2012-03-05T15:24:58Z

@andrewdavey, do you want me to try and keep this in-sync with all your latest changes? Or will you be taking care of that when you merge this in?

andrewdavey · 2012-03-05T15:29:14Z

If you've got the time to re-sync this branch then please do. I'm very busy this week, so I'll take all the help I can get :) Thanks!

…ork around dynamic keyword. Including Iron/SASS dependencies in Nuget package instead of as dependency references to keep one Nuget package. Might need to include licenses if we do this.

kamranayub · 2012-03-05T23:14:11Z

I synced all the changes, however I don't think we can support SASS just yet for FX35 (or ever?). I was able to compile IronRuby against 3.5, but it seemed to have some underlying references to .NET 4. Furthermore, the SassAndCoffee package is targeted at .NET 4, so we'd need to fix all of that... and finally, the SassCompiler is using the dynamic keyword and we'd need to work around that. Blah.

Also, I had to manually include all the SASS dependencies in the lib40 folder of Cassette's Nuget package... this might require us to include the licenses for IronRuby and SassAndCoffee. We could split it out (again, hard for people to upgrade), make it a separate dependency (Cassette.Sass), or wait until Nuget 1.8 (approximately) supports targeted dependencies.

PS. I did not try to convert the Jasmine project to FX35. Maybe I'll try later this week but it's dependent on WebActivator, but only to add routes so maybe we can have extra instructions for people when using FX35.

andrewdavey · 2012-03-06T09:05:13Z

That's unfortunate. I wonder what the ETA on Nuget 1.8 is? Framework targeted dependencies would solve most of our problems, since I don't mind saying Sass support is only for .NET 4 and above.

A temporary solution for .NET 3.5 is to not create a nuget package, but simply provide binaries the old school way i.e. a zip file :)

Once Nuget supports targeted dependencies, we can roll them into the main nuget package.

kamranayub · 2012-03-06T14:37:01Z

We could do that, especially now that there is more of a difference between versions (and might continue to be). Could use MSBuild ext pack to zip automatically or else can just copy the required DLLs to a directory and zip it manually to upload to GitHub. Could also go full throttle and auto-upload to Github when using NugetPush target.

Since it's temporary, the manual method would probably be just fine.

andrewdavey · 2012-03-06T15:43:04Z

I'm okay with a manual approach for now :)

…leases until Nuget supports targeted dependencies. Output goes to build\Cassette.Fx35-{version}

kamranayub · 2012-03-06T20:49:45Z

Alright, it's done... will need to update the web doc though now to include some new steps.

kamranayub · 2012-03-12T15:10:54Z

Nice and clean merge of 1.2.0 done!

andrewdavey · 2012-03-12T15:19:10Z

Awesome!!

andrewdavey · 2012-03-13T22:48:33Z

Merged!

I made some minor edits to remove unused members, internalize some types and cleaned up usings to keep ReSharper quiet :) There's still an odd issue with the Conditional references where ReSharper gets confused an tries to use both. I can probably live with the false error for now.

I'll do some more testing and should be able to get a release out next weekend.

Thanks again for all the work here.

kamranayub · 2012-03-13T23:14:07Z

Wow, some people are gonna be real happy. Thanks for being patient with all
the questions!

On Tue, Mar 13, 2012 at 5:48 PM, Andrew Davey <
reply@reply.github.com

wrote:

Merged!

I made some minor edits to remove unused members, internalize some types
and cleaned up usings to keep ReSharper quiet :) There's still an odd issue
with the Conditional references where ReSharper gets confused an tries to
use both. I can probably live with the false error for now.

I'll do some more testing and should be able to get a release out next
weekend.

Thanks again for all the work here.

Reply to this email directly or view it on GitHub:
#191 (comment)

Kamran Ayub

kamranayub added 30 commits February 8, 2012 10:30

Committing progress on Cassette project 3.5 migration

28c0bad

Add index file workaround to support IsolatedStorage in .NET 3.5

78d2f8d

Merge branch 'master' into dotnet-35

0895439

Conflicts: src/Cassette/CassetteApplicationContainerFactoryBase.cs

Fix local merge problem

1dcd248

[andrewdavey#168] Last change to make Cassette and UnitTests all pass

5de232b

Added preprocessor directives NET35 and NET40 along with conditional …

2339419

…includes in csproj file for Cassette project to support multi-targeting.

[andrewdavey#168] Views and Web projects now support 3.5

1c520e5

[andrewdavey#168] Fix null reference in String.Join for IntegratedTests

6def330

Fix UTC dates in unit tests

875ac3b

Merge branch 'master' into dotnet-35

6a91ed4

[andrewdavey#168] Fix FX35 xml writer implementation for CassetteMani…

d1393ab

…festWriter

Added FX35 build to build.bat and build.xml; need a way to combine th…

524c829

…e packages

Merging lastest master into branch

10ddc78

Updated latest changes to work with FX35 (CoffeeScript compiler, LESS)

2f42d85

Merge branch 'master' of https://github.com/andrewdavey/cassette.git …

128cae5

…into dotnet-35

Added FX35 example site (working in debug/non-debug mode)

ec223c8

[andrewdavey#168] Added .NET 3.5 configuration to documentation

9455409

Added a new page to website documentation for how to configure Cassette in .NET 3.5

Updated Nuget packing

6d4f929

Changed how Nuget packaging works to support multiple framework targeting. Updated Fx35 docs with a gotcha I ran into during testing.

Made build test both lib40 and lib35 assemblies; removed index file w…

b75828d

…orkaround in IsolatedStorageFile and opted to throw NotImplementedException instead for LastWriteTime

[andrewdavey#168] Forced to port UnitTests, IntegrationTests, and MSB…

94941e6

…uild to 3.5 as well. All tests pass and everything is green. Nuget packages are ackaged correctly based on local feed test. This is a fully stable (and working) commit!

[andrewdavey#168] Remove unused xunit task

617588a

[andrewdavey#168] Fixed Nuget symbol package generation

20bfc27

Streamlined FX35 development (Debug-FX35, Release-FX35 configurations…

5641500

…); Fixed Cassette nuspecs to use Pandora.dll from lib35/lib40 folder.

Remove unused junk CodeAnalysis sections from project files

840fa23

Make running example DotNet35 site simpler (Debug-FX35 configuration)…

3a5128d

…; fix NET40 constant not being in Views or Web

Instead of commenting out, wrapped net40 specific test within pragma

57858f7

Clean up some reference warnings; make sure native Lazy type is used …

04bdeff

…in 4.0 mode; fix OpenFile extension method

Added a short contributing doc for .NET 3.5 gotchas and general refer…

9cab914

…ence for other peeps

Moved the contributing doc; added link from readme

fcc264f

Move around contrib doc some more to be compat with github

3cc15b1

kamranayub reviewed Feb 26, 2012
View reviewed changes

kamranayub added 2 commits February 26, 2012 15:02

Merged v1.1 changes in from master

a5fd4cb

Fixed String.Join; added needed overloads to Bundles for FX35 compati…

b9b0819

…bility

kamranayub added 4 commits March 5, 2012 12:50

Merging in latest changes from master (unstable)

ba33415

Make sure .NET 4 projects build and pass all tests

ef845d1

Added IronRuby Clr2 assemblies

d349727

Stable (green). No SASS/SCSS support for FX35 (sorry) unless we can w…

cf48bdf

…ork around dynamic keyword. Including Iron/SASS dependencies in Nuget package instead of as dependency references to keep one Nuget package. Might need to include licenses if we do this.

Removing lib35 stuff from Nuget packages and opting for manual zip re…

1900797

…leases until Nuget supports targeted dependencies. Output goes to build\Cassette.Fx35-{version}

kamranayub added 2 commits March 6, 2012 16:09

Commit saved csproj

f619075

Merged in v1.2.0 changes from upstream/master

da16a84

andrewdavey merged commit da16a84 into andrewdavey:master Mar 13, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add .NET 3.5 Backwards Compatibility #191

Add .NET 3.5 Backwards Compatibility #191

kamranayub commented Feb 26, 2012

kamranayub Feb 26, 2012

andrewdavey commented Feb 26, 2012

kamranayub commented Feb 26, 2012

kamranayub commented Feb 26, 2012

kamranayub commented Mar 5, 2012

andrewdavey commented Mar 5, 2012

kamranayub commented Mar 5, 2012

andrewdavey commented Mar 6, 2012

kamranayub commented Mar 6, 2012

andrewdavey commented Mar 6, 2012

kamranayub commented Mar 6, 2012

kamranayub commented Mar 12, 2012

andrewdavey commented Mar 12, 2012

andrewdavey commented Mar 13, 2012

kamranayub commented Mar 13, 2012

Add .NET 3.5 Backwards Compatibility #191

Add .NET 3.5 Backwards Compatibility #191

Conversation

kamranayub commented Feb 26, 2012

Goals

Rundown

Potential Issues

kamranayub Feb 26, 2012

Choose a reason for hiding this comment

andrewdavey commented Feb 26, 2012

kamranayub commented Feb 26, 2012

kamranayub commented Feb 26, 2012

kamranayub commented Mar 5, 2012

andrewdavey commented Mar 5, 2012

kamranayub commented Mar 5, 2012

andrewdavey commented Mar 6, 2012

kamranayub commented Mar 6, 2012

andrewdavey commented Mar 6, 2012

kamranayub commented Mar 6, 2012

kamranayub commented Mar 12, 2012

andrewdavey commented Mar 12, 2012

andrewdavey commented Mar 13, 2012

kamranayub commented Mar 13, 2012