Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong name #18

Closed
andrewdavey opened this issue Jun 17, 2011 · 7 comments
Closed

Strong name #18

andrewdavey opened this issue Jun 17, 2011 · 7 comments

Comments

@andrewdavey
Copy link
Owner

@blowdart on twitter is asking for a strong name

@robitar
Copy link

robitar commented Aug 12, 2011

Second this, I've set it up locally and done all the messy InternalsVisibleTo stuff, but the test project wont build because 'Should' isn't strong named either. I left it there and just got on with the job at hand.

Would be great to get it sorted, I hate having to maintain a dependency outside of nuget nowadays, could the Should class just be copied directly into the test project?

@andrewdavey
Copy link
Owner Author

Version 0.6.2 is now strongly named and in nuget. Please give it a go and make sure everything is working for you.

(Sorry this took so long to sort out - I've been side tracked by many other projects!)

@robitar
Copy link

robitar commented Aug 15, 2011

No worries, I'm swamped myself.

I tried out the nuget package, but it looks like Postal.dll has no strong name, it also looks like the assembly version is still 0.6.0.0, is it possible the wrong build snuck into the nuget package?

Also I forgot to ask you to put in a CLSCompliant(true) attribute in the AssemblyInfo, otherwise the compiler complains when you derive from Email in an assembly which does have it.

Thanks for all the great work, really looking forward to using this one.

@andrewdavey
Copy link
Owner Author

Hmm, I seem to fail at nuget! I'll try to take a look this evening.

@robitar
Copy link

robitar commented Aug 15, 2011

No worries, I'll check it out when it goes up again

@andrewdavey
Copy link
Owner Author

Please try v0.6.3. That should now have the new, strong named, DLL as well as being CLSCompliant.

@robitar
Copy link

robitar commented Aug 16, 2011

That did it, thanks for the fast turnaround, appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants