Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missuse of updateCoeffs. #3

Closed
dirkgruending opened this issue Mar 18, 2020 · 1 comment
Closed

Missuse of updateCoeffs. #3

dirkgruending opened this issue Mar 18, 2020 · 1 comment

Comments

@dirkgruending
Copy link

updateCoeffs is supposed to update the value of the field on boundaries based on internal values.
Please put it into a function called, e.g., overwriteBoundaryValues. This function can be called from updateCoeffs, but at least this would clarify that it is prescribing an external value from the model.

@AndreWeiner
Copy link
Owner

I was not aware of this convention. I did not really put too much thought into the design of the boundary condition because I simply copied an available derived type boundary condition and modified some names and a few lines of functional code. If you would like to improve the code design, I'll be very thankful for a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants