Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default keymappings to be changed with simple configuration #44

Closed
andrewferrier opened this issue Jan 12, 2023 · 2 comments · Fixed by #88
Closed

Allow default keymappings to be changed with simple configuration #44

andrewferrier opened this issue Jan 12, 2023 · 2 comments · Fixed by #88
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@andrewferrier
Copy link
Owner

https://www.reddit.com/r/neovim/comments/1099agb/comment/j3x5w0w/

@andrewferrier
Copy link
Owner Author

Re-reviewing this I've decided to leave this as-is. There is already a a way of customizing keymappings that's well documented for advanced users, and for novice users the out-of-the-box keymappings are OK. Although I could add a mappings table as per the Reddit discussion, I've also been convinced that there are advantages in the other direction (e.g. for folks who like to centralize their keymappings).

That, combined with the 'if it ain't broke don't fix it' principle, means I'm going to not implement this unless I get specific feedback that people want it and prefer it.

@andrewferrier
Copy link
Owner Author

I'm reopening this for implementation; this has caused confusion twice now because of the need for <expr> mappings; see #75 and #66. Let's do this as an OOB default, maybe maintaining the older approach (deprecated) for backward-compat.

@andrewferrier andrewferrier reopened this Jan 17, 2024
@andrewferrier andrewferrier self-assigned this Jan 18, 2024
@andrewferrier andrewferrier changed the title Allow default keymappings to be changed with simple configuration (whilst continuing to document callback funcs for advanced use) Allow default keymappings to be changed with simple configuration Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant