clpallette broken

[wijjy]

Something is wrong. I don't know if it is the API or your code. Code for clpallete and clpalettes returns error codes.

Thank you.

palette1 <- clpalette('113451')
Opening and ending tag mismatch: input line 114 and form
Opening and ending tag mismatch: input line 114 and div
Opening and ending tag mismatch: input line 114 and div
Opening and ending tag mismatch: form line 114 and div
Entity 'bull' not defined
Entity 'bull' not defined
Opening and ending tag mismatch: div line 114 and body
Opening and ending tag mismatch: div line 114 and html
EndTag: '</' not found
Error: 1: Opening and ending tag mismatch: input line 114 and form
2: Opening and ending tag mismatch: input line 114 and div
3: Opening and ending tag mismatch: input line 114 and div
4: Opening and ending tag mismatch: form line 114 and div
5: Entity 'bull' not defined
6: Entity 'bull' not defined
7: Opening and ending tag mismatch: div line 114 and body
8: Opening and ending tag mismatch: div line 114 and html
9: EndTag: '</' not found

[donny-son]

I think there was a change in the API.

[MartinMSPedersen]

The code fails on this line:

        p <- xmlParse(response, options = XML::NOCDATA)

in R/clQuery.R

[fabianwabbel]

This is a quick fix in file clQuery.r

Reason: Seems Cloudflare does not allow Curl to access the api.

response <- GET(url, user_agent("Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0"))

@andrewheiss, maybe you can add this one?

[MartinMSPedersen]

This is a quick fix in file clQuery.r

Reason: Seems Cloudflare does not allow Curl to access the api.

response <- GET(url, user_agent("Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0"))

@andrewheiss, maybe you can add this one?

Sorry but no. It is not a user_agent problem. It is colourlovers that returns misformed xml.

[MartinMSPedersen]

It is colourlovers api that ask for a captcha
https://www.colourlovers.com/forums/2,5,343389/api_broken._asking_for_captcha...

[MartinMSPedersen]

I have solved this problem and created a PR!
Huray!
#17

[MartinMSPedersen]

Now it works. Until the PR is accepted, you can use my version:

devtools::install_github("martinmspedersen/colourlovers")
library(colourlovers)
clpalette('1')

Palette ID: 1
Title: metro
Created by user: COLOURlover
Date created: 2004-12-27 14:53:30
Views: 114754
Votes: 1432
Comments: 47
Hearts: 5
Rank: 55
URL: http://www.colourlovers.com/palette/1/metro
Image URL:
Colors: #515151, #FFFFFF, #00B4FF, #EEEEEE

[andrewheiss]

Thanks for figuring this out!

[MartinMSPedersen]

New problem and a fix:
49f405c