new feature: deactivate/activate automatic dependency creation using ... #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 20, 2015 11:59
| } | ||
| else | ||
| { | ||
| logger.info("Automatic dependecy creation deactivated!") |
There was a problem hiding this comment.
Typo: dependecy -> dependency
|
Thanks for the PR. Can you please document the new parameter in the README.md. Then I'll get this merged in. |
added 2 commits
July 21, 2015 10:24
…nd a brief description
|
Sure, good point. I forgot about that, but now the README is up-to-date and I've fixed the typo. If anything else needs to be fixed prior to merging, just let me know. BTW, thank you for providing the plugin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... a property switch.
Reason: for testing the google protocol buffers 3.0.0 alpha the automatic dependency creation feature fails as the protoc version differs from the name of the runtime library. In order to allow the manual creation of the proper dependency, it was necessary for me to be able to deactivate the automatic creation.
Maybe this is useful for someone else as well ...
All the best,
l00tr