Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

TextHotKey - key bindings #274

Open
Dzienny opened this issue Jul 18, 2014 · 2 comments
Open

TextHotKey - key bindings #274

Dzienny opened this issue Jul 18, 2014 · 2 comments

Comments

@Dzienny
Copy link
Contributor

Dzienny commented Jul 18, 2014

TextHotKey extension doesn't work. I noticed that there is some code to handle this extension, but it hasn't been finished.

Also, the extension should have a new behaviour that would allow the server to easily remove all the key bindings with one packet. I suggest that could be done with, for example, a packet that contains KeyCode equal to 0.

If someone feels like implementing it - the new release of MCDzienny (11.8) has a plugin that could be helpful for testing. It's in plugins tab -> Keyboard Shortcuts. It provides server side implementation for TextHotKey extension. Mind that currently this feature of MCDzienny works only on Windows, the mono version hasn't been done yet.

@Jonty800
Copy link
Collaborator

The feature was unfinished because LWJGL didn't support key modifier flags. The flags indicate which combination of CTRL, SHIFT, and ALT keys was pressed

@Dzienny
Copy link
Contributor Author

Dzienny commented Jul 18, 2014

Lwjgl reads these keys (ctrl, shift, alt) directly, so the flags can be added manually.

Actually, some flags are there already -> https://github.com/andrewphorn/ClassiCube-Client/blob/master/src/main/java/com/mojang/minecraft/player/InputHandlerImpl.java

Example:
If the hacks are on, then:
keylist[7] is a flag for SHIFT
keylist[8] is a flag for CTRL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants