Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gulp -m all -l all build:dev fails on OS that cares about case in file names #654

Open
jikamens opened this issue Aug 4, 2019 · 0 comments · May be fixed by #663
Open

gulp -m all -l all build:dev fails on OS that cares about case in file names #654

jikamens opened this issue Aug 4, 2019 · 0 comments · May be fixed by #663

Comments

@jikamens
Copy link
Contributor

jikamens commented Aug 4, 2019 

[11:32:34] Using gulpfile /tmp/Sugar/gulpfile.js
[11:32:34] Starting 'build:dev'...
[11:32:34] Exporting: sugar-custom.js...
[11:32:34] Cannot find locale zh-CN!
[11:32:34] Exiting...

This fixes it for me:

diff --git a/gulpfile.js b/gulpfile.js
index ee3c7aa4..9b9d2e63 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -793,7 +793,7 @@ function getLocalePaths(l) {
   var codes = getLocaleCodes(l);
 
   function getPath(l) {
-    return path.join('lib', 'locales', l.toLowerCase() + '.js');
+    return path.join('lib', 'locales', l + '.js');
   }
 
   codes.forEach(function(n) {
jikamens added a commit to jikamens/Sugar that referenced this issue Aug 5, 2019
@jikamens
Don't convert locale directory names to lower case
1aa90d7 
Fixes andrewplummer#654
@jikamens jikamens mentioned this issue Aug 5, 2019
Closed
jikamens added a commit to jikamens/Sugar that referenced this issue Nov 21, 2019
@jikamens
Don't convert locale directory names to lower case
76c3d0f 
Fixes andrewplummer#654
@jikamens jikamens linked a pull request Nov 21, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't convert locale directory names to lower case jikamens/Sugar
1 participant
@jikamens