-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching View Controllers causes TimeScroller to "Multiply" #17
Comments
The height of the containing view is calculated wrong and so the scroller image is multiplied. I was running into the same problem and so i fixed the height to a hard coded value. self.frame = CGRectMake(0.0f, 0.0f, 320.0f, 31.0f); // 31.0f is hard coded |
That fixed the issue very quickly, I guess it would be best that this change is made to the posted code though? |
I am not sure if it is a nice solution to fix the height. But normally it should be O.K. |
This is how I fixed it too, hardcoding the height |
@honkmaster @Rich2k I am seeing this too. Which height are you talking about? the container table view? |
We are talking about the height in the TimeScroller itself. |
Thanks, yeah the size seemed weird. I guess it was "cleaner" to not hard code the height so that it auto adjusts to different images, but in practice that is not too terrible. |
fixed issue #17 (Switching View Controllers causes TimeScroller to "Multiply")
This should now be resolved! |
In many navigation based apps I've tested TimeScroller, if you push a new ViewController onto the navigation stack, and then navigate back to the ViewController TimeScroller will do what you see in the screenshot below, if I reinitialize the ViewController with TimeScroller in it it behaves correctly again (which is obvious since the VC is being reinitialized).
Screenshot: http://cl.ly/image/1X1A0q472D0m
I'm not sure if I'm just doing something wrong or not but I literally used the sample code verbatim.
The text was updated successfully, but these errors were encountered: