Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Matrix Question With Dynamic Row add Remove Functionality #34

Closed
mirmdasif opened this issue Jul 13, 2016 · 6 comments
Closed

Comments

@mirmdasif
Copy link

Screenshot Of the Feature

screenshot-localhost 8000 2016-07-13 13-47-30

Basic feature implemented for knockout

https://github.com/mirmdasif/surveyjs/tree/feature/dynamic-row-in-matrix-dropdwon

@andrewtelnov
Copy link
Member

I have just committed the react version and I believe I have done with it. Could you please check it out?

I am going to add examples with this question a little later.

Thank you,
Andrew

@mirmdasif
Copy link
Author

Hi I have tested matrixdynamic dynamic question. So far so good :).

Just one suggestion default value for rowCount is 2. But I think it should be length of data if given or 1. This way user don't have to pass different rowCount every time.

We store survey definition in a template which does not change. For every users only difference is the survey data. Just a suggestion not a big deal.

@andrewtelnov
Copy link
Member

How bad do you need it? I am using incremental row index as an unique id. I can't use just index in the row, because I do not want to recreate all rows on deleting or synchronize indexes.

Thank you,
Andrew

@mirmdasif
Copy link
Author

Honestly speaking I don't need it at all. I have modified my code in such a way that rowCount for a matrixdynamic question is always equals to the length of data. So you may or may not address it as a issue :)

@andrewtelnov
Copy link
Member

Great! :)

@andrewtelnov
Copy link
Member

Example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants