Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for converting IPv6 to Text #11

Closed
Tracked by #22
Porges opened this issue Jul 1, 2017 · 3 comments
Closed
Tracked by #22

Support for converting IPv6 to Text #11

Porges opened this issue Jul 1, 2017 · 3 comments

Comments

@Porges
Copy link
Contributor

Porges commented Jul 1, 2017

IPv4 has encode :: IPv4 -> Text, but the corresponding function doesn't exist for IPv6

@andrewthad
Copy link
Member

This look good. Thanks for writing tests too. Performance won't be great (to get the best performance, you'd have to allocate a buffer unfront and then do writes indexing the appropriate positions), but it's much better to have something slow than nothing ;)

@andrewthad
Copy link
Member

PR has been merged. New hackage realease 0.9.2 includes this and the parser fix.

@Porges
Copy link
Contributor Author

Porges commented Jul 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants