Add HasCallStack constraints to all functions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This is an excellent addition. I don't care about backwards-compatibility for this, so bumping the minimum bound for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this package is exclusively aimed at debugging, getting a callstack on failures is quite helpful in my experience. One thing to consider is backwards compatibility. In this PR I’ve just bumped the lower bound on base to 4.9 which supports the API that is being used here and still covers the 3 release support window that a lot of the Haskell ecosystem sticks to. If you prefer to keep backwards compatibility, we could use a combination of the call-stack package and our own CPP (for
prettyCallStack) but for a package aimed exclusively at debugging, I’m not sure that’s worth the effort.