Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy failing #4

Open
andrewthetechie opened this issue Aug 26, 2021 · 0 comments
Open

Mypy failing #4

andrewthetechie opened this issue Aug 26, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Good hacktoberfest issue help wanted Extra attention is needed

Comments

@andrewthetechie
Copy link
Owner

andrewthetechie commented Aug 26, 2021

Mypy is currently failing. In CI, it is in "fail-open" mode as to not prevent merges.

I was able to clean up most of the failures, but have not been able to track down/fix the last 3 errors

pydantic_aioredis/model.py:134: error: Incompatible types in assignment (expression has type "Generator[Any, None, None]", variable has type "AsyncIterator[Any]")
pydantic_aioredis/store.py:18: error: Invalid type comment or annotation
pydantic_aioredis/store.py:18: note: Suggestion: use type[...] instead of type(...)
pydantic_aioredis/store.py:41: error: Invalid type comment or annotation
pydantic_aioredis/store.py:41: note: Suggestion: use type[...] instead of type(...)
Found 3 errors in 2 files (checked 6 source files)
Makefile:40: recipe for target 'mypy' failed
@andrewthetechie andrewthetechie added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Aug 26, 2021
@andrewthetechie andrewthetechie added the hacktoberfest Good hacktoberfest issue label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Good hacktoberfest issue help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant