Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing poll interval #9

Closed
bcardarella opened this issue Oct 26, 2017 · 2 comments
Closed

Increasing poll interval #9

bcardarella opened this issue Oct 26, 2017 · 2 comments

Comments

@bcardarella
Copy link
Contributor

I've seen intermittent failures to detect that Chrome has launched. In almost all cases I suspect Chrome did launch but not fast enough. The current code appears to have a max timeout of 300ms (10 tries at 30ms each on master)

Looking at the chrome launcher by Google they are also using 10 tries but the delay is 500ms each: https://github.com/GoogleChrome/chrome-launcher/blob/master/chrome-launcher.ts#L119 so the total wait could be up to 5 seconds.

I've tried this size timeout locally and it does appear to clear up any issues I've seen with detecting the process starting.

@bcardarella
Copy link
Contributor Author

Correction, they appear to do 50 retries: https://github.com/GoogleChrome/chrome-launcher/blob/master/chrome-launcher.ts#L120

They comment they have inline must be wrong: https://github.com/GoogleChrome/chrome-launcher/blob/master/chrome-launcher.ts#L258

So their total start up delay could be as long as 25 seconds.

@andrewvy
Copy link
Owner

Hey! Thanks for the info, I'm going to close this issue in favor of #8 to find a more holistic solution around this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants