You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently I see that most types have a reference back to their file as ifc::File const&. This is considered bad practice because it makes the type not copy/move assignable. I suggest keeping the references in the constructor to keep the invariance, but store a pointer in the class.
Currently I see that most types have a reference back to their file as
ifc::File const&
. This is considered bad practice because it makes the type not copy/move assignable. I suggest keeping the references in the constructor to keep the invariance, but store a pointer in the class.This is also backed up by the C++ Core Guidelines C.12.
The text was updated successfully, but these errors were encountered: