Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reflifc types to be assignable. #20

Closed
FireFlyForLife opened this issue Feb 20, 2023 · 0 comments
Closed

Allow reflifc types to be assignable. #20

FireFlyForLife opened this issue Feb 20, 2023 · 0 comments

Comments

@FireFlyForLife
Copy link
Contributor

Currently I see that most types have a reference back to their file as ifc::File const&. This is considered bad practice because it makes the type not copy/move assignable. I suggest keeping the references in the constructor to keep the invariance, but store a pointer in the class.

This is also backed up by the C++ Core Guidelines C.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants