Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old copy of jquery "multiple-select" add-in causing issues with monaco-editor #41

Closed
Steve-Mcl opened this issue Jun 13, 2021 · 1 comment

Comments

@Steve-Mcl
Copy link

Hi, with node-red 2.0.0 now supporting monaco editor it has been discovered that when node-red-contrib-zigbee2mqtt is installed the editor stops working.

See here

I have also tested this and get the same error.

Steps to repeat this issue...

  1. Install latest node-red 2.0.0-beta.1
  2. enable monaco in settings.js
         codeEditor: {
          lib: "monaco",
          options: {
              theme: "vs",
          }
      }
    
  3. Run node-red - editor works as expected
  4. Install node-red-contrib-zigbee2mqtt
  5. Stop and restart node-red & refresh browser
  6. open a function node - editor now broke (cannot types) & console shows error Uncaught Error: e[Symbol.iterator] is not a function

Tracking down the cause was problematic and I am still not certain why it happens however I hound by disabling $.getScript('zigbee2mqtt/static/js/multiple-select.min.js'); in app.html and restarting node-red / refresh browser, the editor now works again.

Further more, I found by replacing node-red-contrib-zigbee2mqtt/static/js/multiple-select.min.js (which is v1.4.2) with the latest version v1.5.2 from here the editor no longer breaks.

I have provided a temporary workaround for users of your node here on the node-red forum

@andreypopov
Copy link
Owner

fixed

  • node-red-contrib-zigbee2mqtt@0.6.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants