Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardwired references to livereloadany #1

Open
chocolateboy opened this issue May 25, 2015 · 2 comments
Open

Hardwired references to livereloadany #1

chocolateboy opened this issue May 25, 2015 · 2 comments

Comments

@chocolateboy
Copy link

Any reason why the source code contains hardwired references to livereloadany? They don't appear to be relevant to a general purpose URL matcher, and look like they might cause unexpected behaviour when matching patterns that happen to contain it as a substring.

@andreyvit
Copy link
Owner

livereloadany is just an arbitrary string, and you're right, a better one should be used (although I doubt that it will ever be a problem in practice). It has to be a string that's valid as part of a hostname for url.parse to succeed, so no funny characters allowed; perhaps something like URLPARSEWILDCARD.

@andreyvit
Copy link
Owner

P.S. Pull requests are welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants