Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong param passing for GA #45

Closed
spaudanjo opened this issue Apr 18, 2021 · 0 comments · Fixed by #46
Closed

Fix wrong param passing for GA #45

spaudanjo opened this issue Apr 18, 2021 · 0 comments · Fixed by #46

Comments

@spaudanjo
Copy link
Contributor

In

gatsby-plugin-gdpr-cookies/src/services/index.js

Line 31 in e921a03

addGoogleAnalytics(options.trackingId).then((status) => {
, the trackingId is deconstructed already in the called method, so the whole options object should be passed in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

45 - fix wrong param passing for addGoogleAnalytics spaudanjo/gatsby-plugin-gdpr-cookies
1 participant
@spaudanjo