Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -jN race on os x #198

Closed
kmshih opened this issue Sep 13, 2016 · 2 comments
Closed

Fix -jN race on os x #198

kmshih opened this issue Sep 13, 2016 · 2 comments
Assignees
@DanAlbert
Labels
ndk-build
Milestone
r18

Comments

@kmshih
Copy link

kmshih commented Sep 13, 2016

Per https://code.google.com/p/android/issues/detail?id=222255 and http://www.egeek.me/2013/11/23/android-ndk-clean-failed-on-fts-read/ there's a race if you do -jN where N>1. Let's de-race it.
@DanAlbert DanAlbert self-assigned this Sep 13, 2016
@DanAlbert DanAlbert added this to the r14 milestone Sep 13, 2016
@DanAlbert DanAlbert removed this from the r14 milestone Jan 4, 2017
@DanAlbert DanAlbert added this to the r18 milestone Mar 16, 2018
@DanAlbert
Copy link
Member

Fix merged into r18.

@rprichard
Copy link
Collaborator

Fixed by https://android-review.git.corp.google.com/c/platform/ndk/+/728877

mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
27826d5 
* Update ndk from branch 'ndk-release-r18'
  to e0bffbf01d6e2ee6c2dfb2579ee9f2d6adac3db4
  - Merge "Fix race in clean with -j on Darwin." into ndk-release-r18
  - Fix race in clean with -j on Darwin.
    
    It looks like the original code here was mistaking TARGET_OBJS (the
    target-specific but not module-specific object directory) with
    LOCAL_OBJS_DIR (the target- and module-specific directory). This was
    causing mutliple `rm -r` of the same directory to run simultaneously,
    which can fail with "rm: fts_read: No such file or directory" on OS X.
    
    Test: ndk-build -B clean V=1
    Bug: android/ndk#198
    Bug: http://b/37119411
    Change-Id: I477f553f1bae5255c38eeddc009d246a87c165b1
    (cherry picked from commit 01838afb0adbbe76fbbb3a68a5853b90190d9110)
    
  - Merge "Explicitly build c++_static." into ndk-release-r18
  - Explicitly build c++_static.
    
    Test: ./checkbuild.py libc++
    Bug: android/ndk#748
    Change-Id: I744b500a2e532698617b83db28f1eba4f87f3102
    (cherry picked from commit 332fe35c740ea125aedb262e3fa554ee2f9c310d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
ndk-build
Projects
None yet
Milestone
r18
Development

No branches or pull requests
3 participants
@DanAlbert @rprichard @kmshih