Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove symbol versions from libGLESv3.so for pre-N #265

Closed
DanAlbert opened this issue Dec 20, 2016 · 1 comment
Closed

remove symbol versions from libGLESv3.so for pre-N #265

DanAlbert opened this issue Dec 20, 2016 · 1 comment
Assignees
@DanAlbert
Milestone
r14

Comments

@DanAlbert
Copy link
Member

Description

The r14 stub libraries are built with symbol version information, which is generally a good thing but means that SONAMEs must be correct. The M CDD actually required that libGLESv3.so was a symlink to libGLESv2.so, which actually means that M devices are required to have a broken libGLESv3.so :(

We can't feasibly fix M at this point, so we need to work around this in the NDK by not versioning libGLESv3.so symbols until N.

CC @dimitry- for fact checking

Environment Details

Not all of these will be relevant to every bug, but please provide as much
information as you can.

  • NDK Version: r14
  • Build sytem: any
  • Host OS: any
  • Compiler: any
  • ABI: any
  • STL: any
  • NDK API level: any
  • Device API level: pre-N
@DanAlbert DanAlbert added this to the r14 milestone Dec 20, 2016
@DanAlbert DanAlbert self-assigned this Dec 20, 2016
@DanAlbert
Copy link
Member Author

https://android-review.googlesource.com/c/318427/

nathanchance pushed a commit to Flash-ROM/build_soong that referenced this issue Jan 5, 2017
@DanAlbert
Support versioned=%d at the section level.
ae452cc 
Test: nose2
Bug: android/ndk#265
Change-Id: I4c22cb8069f41861613ecf01f7e1adbe1d3118a9
nathanchance pushed a commit to Flash-ROM/build_soong that referenced this issue Jan 5, 2017
@DanAlbert
Add unversioned_until to ndk_library.
98dbb3b 
This defaults to the value of first_version, and should almost never
be used. This is only needed to work around platform bugs like
android/ndk#265.

Test: Set `unversioned_until: "24"` for libGLESv3.ndk, readelf on the
      android-23 and android-24 outputs to check for version info.
Bug: android/ndk#265

Change-Id: Ie44b170daad692fdc98e7d7c5f10f9077930b8a9
@DanAlbert DanAlbert mentioned this issue Jan 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
None yet
Projects
None yet
Milestone
r14
Development

No branches or pull requests
1 participant
@DanAlbert