Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensor.h having "bool" type as C interface #370

Closed
ggfan opened this issue Apr 21, 2017 · 3 comments
Closed

sensor.h having "bool" type as C interface #370

ggfan opened this issue Apr 21, 2017 · 3 comments
Assignees
@DanAlbert
Labels
headers
Milestone
r15

Comments

@ggfan
Copy link

ggfan commented Apr 21, 2017

android/sensor.h defines a C interface, but it has a "bool" in it
bool ASensor_isWakeUpSensor(ASensor const* sensor);

ASensor const* ASensorManager_getDefaultSensorEx(ASensorManager* manager, int type,
bool wakeUp);

causing error if not defining "bool" somewhere in the C application.
@enh
Copy link
Contributor

enh commented Apr 21, 2017

i was wondering why this hadn't been noticed before. turns out L44 of the old hacked-about headers was:

#include <stdbool.h>

but this never made it back to the platform headers :-(

@DanAlbert
Copy link
Member

https://android-review.googlesource.com/379777 up for review

@DanAlbert DanAlbert self-assigned this Apr 25, 2017
@DanAlbert DanAlbert added this to the r15 milestone Apr 25, 2017
xosgerrit pushed a commit to halogenOS/android_frameworks_native that referenced this issue May 3, 2017
@DanAlbert
Add missing stdbool.h to sensor.h.
90c350a 
This got hacked into the NDK headers ages ago, but never got
upstreamed to the frameworks.

Test: make checkbuild
Bug: android/ndk#370
Merged-In: Id38cbc96633c1c61de36996c2dd9e6c2331bd6e7
Change-Id: Id38cbc96633c1c61de36996c2dd9e6c2331bd6e7
Signed-off-by: Simao Gomes Viana <xdevs23@outlook.com>
@DanAlbert
Copy link
Member

Merged into r15.

h7su pushed a commit to h7su/android_platform_frameworks_native that referenced this issue Apr 22, 2024
@DanAlbert
Add missing stdbool.h to sensor.h.
dbd516d 
This got hacked into the NDK headers ages ago, but never got
upstreamed to the frameworks.

Test: make checkbuild
Bug: android/ndk#370
Change-Id: Id38cbc96633c1c61de36996c2dd9e6c2331bd6e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
headers
Projects
None yet
Milestone
r15
Development

No branches or pull requests
3 participants
@DanAlbert @enh @ggfan