Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-googletest-full fails on armeabi with the clang update #374

Closed
DanAlbert opened this issue Apr 28, 2017 · 4 comments
Closed

test-googletest-full fails on armeabi with the clang update #374

DanAlbert opened this issue Apr 28, 2017 · 4 comments
Assignees
@DanAlbert
Labels
clang
Milestone
unplanned

Comments

@DanAlbert
Copy link
Member

https://android.googlesource.com/platform/ndk/+/master/sources/cxx-stl/gabi++/src/cxxabi.cc#135 is segfaulting after we update clang. https://android.googlesource.com/platform/ndk/+/master/sources/cxx-stl/gabi++/src/cxxabi.cc#153 is returning true but still has free_items_ set to NULL. Current guess is that we're hitting some undefined behavior and https://android.googlesource.com/platform/ndk/+/master/sources/cxx-stl/gabi++/src/cxxabi.cc#167 is being optimized out, but just marking as broken for now.
@DanAlbert DanAlbert added this to the r15 milestone Apr 28, 2017
@DanAlbert DanAlbert self-assigned this Apr 28, 2017
@DanAlbert
Copy link
Member Author

Correction: this affects armeabi-v7a too.

@DanAlbert DanAlbert changed the title test-googletest-full fails on armeabi with the clang update test-googletest-full fails on arm32 with the clang update Apr 28, 2017
@DanAlbert DanAlbert changed the title test-googletest-full fails on arm32 with the clang update test-googletest-full fails on armeabi with the clang update May 1, 2017
@DanAlbert
Copy link
Member Author

False alarm. Couldn't repro on arm7.

a252539783 pushed a commit to a252539783/aosp-platform-ndk that referenced this issue May 3, 2017
@DanAlbert
Mark test-googletest-full broken for armeabi.
b227a4e 
gabi++ is broken for armeabi when built with Clang.

Test: ./validate.py --filter test-googletest-full
Bug: android/ndk#374
Change-Id: I21589fdb00bbaa35768e63827a5bcaad8a724025
(cherry picked from commit 521f80f)
a252539783 pushed a commit to a252539783/aosp-platform-ndk that referenced this issue May 3, 2017
@DanAlbert
Mark test-googletest-full broken for armeabi.
521f80f 
gabi++ is broken for armeabi when built with Clang.

Test: ./validate.py --filter test-googletest-full
Bug: android/ndk#374
Change-Id: I21589fdb00bbaa35768e63827a5bcaad8a724025
@DanAlbert DanAlbert modified the milestones: r16, r15 Jun 8, 2017
@DanAlbert DanAlbert added the clang label Aug 4, 2017
@DanAlbert
Copy link
Member Author

Doesn't happen with Oz.

@DanAlbert DanAlbert modified the milestones: r16, r17, unplanned Oct 3, 2017
@DanAlbert
Copy link
Member Author

gabi++ will be gone soon enough, and we don't default to Os any more anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
clang
Projects
None yet
Milestone
unplanned
Development

No branches or pull requests
1 participant
@DanAlbert