Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined reference to 'iconv_open' #702

Closed
xclaesse opened this issue May 19, 2018 · 7 comments
Closed

undefined reference to 'iconv_open' #702

xclaesse opened this issue May 19, 2018 · 7 comments
Assignees
@DanAlbert
Milestone
r17b

Comments

@xclaesse
Copy link

xclaesse commented May 19, 2018 •
edited
Loading

Android NDK r17 has iconv.h that declares iconv_open() if __ANDROID_API__ >= 28, but when I use that symbol it fails to link. If I add -liconv the linker cannot find that library. I think they should be defined in libc, right?

grep iconv_open ./platforms/android-28/arch-arm64/usr/lib/libc.so gives nothing
grep iconv_open ./platforms/android-28/arch-arm64/usr/lib/libc.a match
@DanAlbert DanAlbert self-assigned this May 21, 2018
@DanAlbert DanAlbert added this to the r17b milestone May 21, 2018
@DanAlbert
Copy link
Member

It looks like there's something that got broken in the branch we've been taking P API blobs from. Could be as simple as a bad merge. AOSP master is generating the right things.

@DanAlbert
Copy link
Member

Scratch that, the P branch is actually fine. It wasn't when we pulled the prebuilts for r17, but is now. Will update for r17b.

@DanAlbert
Copy link
Member

https://android-review.googlesource.com/c/platform/prebuilts/ndk/+/690308

@epicstar
Copy link

Interesting... Does this mean that iconv is available in devices starting API 28?

@enh
Copy link
Contributor

enh commented May 22, 2018

yes: https://android-review.googlesource.com/c/platform/bionic/+/464455

@DanAlbert DanAlbert mentioned this issue Jun 8, 2018
Closed
@trapacska trapacska mentioned this issue Jun 13, 2018
Merged
@xclaesse
Copy link
Author

I tried with r17b and it works. Thanks.

@groege groege mentioned this issue Sep 20, 2019
Open
@JaeHoLee1811

This comment has been minimized.

Sign in to view
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
9781c47 
* Update ndk from branch 'master'
  to 3a21fd712122f16879ce937f0041c7b34a966c17
  - Merge "Test emutls pthread key deletion"
  - Test emutls pthread key deletion
    
    The key should be deleted when an solib is dlclose'd, but __thread
    variables should continue working during cleanup functions.
    
    Bug: b/80453944
    Test: manual
    Change-Id: Ie5719f6228911d4e9f8f58b86f994765a713691f
    

* Update prebuilts/ndk from branch 'dev'
  to f0908f8e2856919868742937450d197b08d37073
  - Merge "Update prebuilt GCC to build 4886780." into dev
  - Update prebuilt GCC to build 4886780.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: android/ndk#505
    Bug: http://b/80453944
    Change-Id: I1bd7fe862704a10f24806de23bc67ec3f15e4cb4
    
  - Merge "Update prebuilt GCC to build 4856068." into dev
  - Update prebuilt GCC to build 4856068.
    
    Update libgcc.a with a change to defer per-thread emutls cleanup by one
    round.
    
    Bug: android/ndk#687
    Bug: b/78022094
    Test: ./checkbuild.py && ./run_tests.py --filter=emutls-dealloc
    Change-Id: I413b4bd926472bb50865d4b91431302f803a49e6
    
  - Merge "Update NDK platform prebuilts to build 4828202." into dev
  - Update NDK platform prebuilts to build 4828202.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: None
    Change-Id: Ib963ec9d8afe1ff84dc9586eb774aad6c9d1236b
    
  - Merge "Update NDK platform prebuilts to build 4811751." into dev
  - Update NDK platform prebuilts to build 4811751.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: None
    Change-Id: If2aaaf6fe05ea63c8e340908f8f00d218219ddfb
    
  - Merge "Update NDK platform prebuilts to build 4794421." into dev
  - Update NDK platform prebuilts to build 4794421.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: android/ndk#702
    Change-Id: I84362b1b3f1bec6236866cdae617a811abfd5f52
    
  - Merge "Update prebuilt Clang to build r328903." into dev
  - Merge "Adapt to the new Clang naming scheme." into dev
  - Adapt to the new Clang naming scheme.
    
    Clang prebuilts are now named as clang-r${REVISION}${PATCH} rather
    than as clang-${BUILD_NUMBER}.
    
    Test: ./symlink-clang.py
    Bug: None
    Change-Id: I758feecb05ad568560333f63d3e0e9cdc25f9bcd
    
  - Update prebuilt Clang to build r328903.
    
    Change-Id: I07c5832446733f09aa48ff8a0c13d89516e69370
    
  - Merge "Update NDK platform prebuilts to build 4753280." into dev
  - Update NDK platform prebuilts to build 4753280.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: None
    Change-Id: Ic062d17cf3a7de3c82ea1d9a875c6cb3dc141b23
    
  - Merge "Update prebuilt binutils to build 4724899." into dev
  - Merge "Don't fetch the repo.prop for platform prebuilts." into dev
  - Don't fetch the repo.prop for platform prebuilts.
    
    Not necessary.
    
    Test: ./update_platform.py ...
    Bug: None
    Change-Id: I079c65caedaf5c1a3f270af721133051aee00c0b
    
  - Update prebuilt binutils to build 4724899.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: None
    Change-Id: I951f53a8bfc258eb4501df8d84e255bd1e1cc1f1
    
  - Merge "Update prebuilt Clang to build 4691093." into dev
  - Update prebuilt Clang to build 4691093.
    
    Change-Id: Ibe8c95936a0bbb46a172f8efcd4a00386dfa5e8c
    
  - Merge "Update Validation layer binaries" into dev
  - Merge "Update prebuilt Clang to build 4639204." into dev
  - Update Validation layer binaries
    
    Build: 4634174
    
    https://android-build.googleplex.com/builds/branch-dashboard/aosp-master-ndk-vulkan-validation-layers?build_id=4634174
    
    Change-Id: I55d4ca67aa390d288c6c0f04bbafb21dee31aab8
    
  - Merge "Update NDK platform prebuilts to build 4634113." into dev
  - Update prebuilt Clang to build 4639204.
    
    Change-Id: I456b400bc534de579078665a48ae5235869fb3f3
    
  - Update NDK platform prebuilts to build 4634113.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: None
    Change-Id: I9e7aa333073c61ba2724a6cd39f7b7e30ff2fef6
    
  - Merge "Update prebuilt Clang to build 4630689." into dev
  - Merge "Update NDK platform prebuilts to build 4634436." into dev
  - Update NDK platform prebuilts to build 4634436.
    
    Test: ndk/checkbuild.py && ndk/run_tests.py
    Bug: None
    Change-Id: Idd13dfe5dc9b928b81b48a0e72dc8ae669739275
    
  - Update prebuilt Clang to build 4630689.
    
    Change-Id: I852722d2bdfb4aeaa42fe943677d7adbf679d61b
@SSE4 SSE4 mentioned this issue Sep 2, 2021
Closed
msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.ndk that referenced this issue Aug 27, 2022
@DanAlbert
Update NDK platform prebuilts to build 4794421.
e91f9f5 
Test: ndk/checkbuild.py && ndk/run_tests.py
Bug: android/ndk#702
Change-Id: I84362b1b3f1bec6236866cdae617a811abfd5f52
(cherry picked from commit ca3d771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
None yet
Projects
None yet
Milestone
r17b
Development

No branches or pull requests
5 participants
@DanAlbert @xclaesse @enh @epicstar @JaeHoLee1811