Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ndk-build shouldn't mess up PYTHONHOME #904

Closed
enh opened this issue Feb 5, 2019 · 1 comment
Closed

[BUG] ndk-build shouldn't mess up PYTHONHOME #904

enh opened this issue Feb 5, 2019 · 1 comment
Assignees
@DanAlbert
Labels
bug
Milestone
r21

Comments

@enh
Copy link
Contributor

enh commented Feb 5, 2019

in googlesamples/vulkan-basic-samples#25 we had an issue where folks ended up using the NDK python by accident.
@enh enh added the bug label Feb 5, 2019
@DanAlbert DanAlbert self-assigned this Sep 19, 2019
@DanAlbert DanAlbert added this to the r21 milestone Sep 19, 2019
@DanAlbert
Copy link
Member

https://android-review.googlesource.com/c/platform/ndk/+/1127564

disigma pushed a commit to wimal-build/ndk that referenced this issue Sep 24, 2019
@DanAlbert
Unset PYTHONPATH and PYTHONHOME in ndk-build.
6bbd53b 
ndk-build calls into our own shipped Python, and if the user has their
own conflicting Python install referred to by PYTHONHOME or PYTHONPATH
that can cause issues.

Test: ./checkbuild.py
Bug: android/ndk#904
Bug: googlesamples/vulkan-basic-samples#25
Change-Id: I1e0c3091e67c866e5e908c054fd2b5e45e80e58b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
bug
Projects
None yet
Milestone
r21
Development

No branches or pull requests
2 participants
@DanAlbert @enh