Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to automatically sync #277

Closed
stuart12 opened this issue Feb 27, 2017 · 17 comments
Closed

add option to automatically sync #277

stuart12 opened this issue Feb 27, 2017 · 17 comments
Labels
A-Git Area: Git A-UI-UX Area: General UI/UX concerns C-feature Category: This is a feature request E-medium Effort: This requires a fair amount of work P-low Priority: low S-design Status: There's a problem here, but no obvious solution; or the solution raises other questions S-help-wanted Status: This issue could use external help with implementation
Milestone

Comments

@stuart12
Copy link

It would be great if Android-Password-Store automatically synced the git respository. This is for two reasons. I'm not always connected and would like to have any changes pushed automatically when I next connect. Also, I will never remember to sync when I am connected and so will find myself with stale passwords or conflicts if I edit the same password entry on two devices.

A possible specification: if the local store is dirty Android-Password-Store should sync immediately if connected otherwise at next connection. Otherwise Android-Password-Store should pull every time the app is opened (with a minimum time between pulls). It should also pull at least once a day if connected or at the next connection. It would be good if the sync at opening could be in the background and just update the display if new data arrives.

Perhaps this should be two tickets. One which pushes if dirty and another to implement background pulling.

This should not be implemented before #276 is fixed.

@JuliCodes
Copy link

Hey,

just a thought about this feature. Yes truly this would be a nice function. But currently you need a password for the sync. And i highly discourage from running a password less sync, as then somebody could overwrite your passwords....

So in a way the app has to ask for your password. Maybe the app could look when you open it, if there is a connection and suggest a sync, if the last one is older than a certain amount of time, or the local version has unsynced commits.

Greetings

@stuart12
Copy link
Author

Well, I don't need a password for syncing as I have a ssh-key without a password. I'd rather have the ssh-key encrypted with the same password as the password for the GPG key and have them linked but that doesn't seem to be an option at the moment.

@JuliCodes
Copy link

Yes, you have that :D My humble opinion was more a general point.

@ruvido
Copy link

ruvido commented Mar 11, 2017

A bit puzzled here. I have generated an ssh-key within the app, uploaded it to github. When I sync, I always get asked for the ssh password. Is there a way to avoid this?

@zeapo
Copy link
Contributor

zeapo commented Mar 15, 2017

@ruvido You get asked for a passphrase automatically because we do not keep any information about your passphrase.
IMO, an ssh-key has to have a passphrase most of the time, especially in this case.

We could add an option to remember the ssh-key passphrase, by storing it encrypted using the gpg key. But we wont' encrypt the ssh-key itself using gpg.

In the future we'd like to use a gpg subkey for ssh authentication, but that's another story.

@ibrokemypie
Copy link

Why not pull upon launch, and push whenever changes are made?

@zeapo
Copy link
Contributor

zeapo commented Oct 2, 2017

@ibrokemypie This is the way I'm imagining it to be. It would also have a time limite such as one pull every hour or so.

@stuart12
Copy link
Author

In a comment in #378, I suggest allowing the user the select an password entry in the store which is the SSH passphrase. Once this is done, whenever the GPG key is unlocked we have the SSH passphrase. So when the GPG key is unlocked we can push if there is something to push and to pull if a timeout has expired (we could have two timeouts: one for WiFi and the other for data).

@nicobo
Copy link

nicobo commented Jun 4, 2020

Hi. Is there any news about this feature ?

I'm using qtpass on an everyday basis : it automatically refreshes updates and pushes whenever a change occurs and works great for me (git server with ssh key, no password as ssh key is for headless access)

@msfjarvis
Copy link
Member

Hi. Is there any news about this feature ?

Not at the moment, and it's unlikely to make it into the June release regardless — we have a lot of changes ongoing and don't have the development bandwidth. I'll consider this for the July release when the time for that comes around.

@Skrilltrax
Copy link
Member

@msfjarvis we discussed an option to sync every time the app is launched. Want to implement it that way?

@msfjarvis
Copy link
Member

@msfjarvis we discussed an option to sync every time the app is launched. Want to implement it that way?

I can get behind that.

@Skrilltrax
Copy link
Member

Cool, I can take a look at it later today.

@dm17
Copy link

dm17 commented Nov 20, 2020

Do you guys do 1 git repo per password sharing group/org?
For organizations that update and then share passwords, I'm wondering what the best process is - especially considering the manual nature of git syncing. A CI/CD-like system for each password repository in git seems like overkill, for example. But every time a password is updated, then one should certainly 'git push'. A local script could also be run so a 'git pull' is run every time pass is unlocked. Thoughts?

@akselaase
Copy link

Should this be re-opened since the feature was reverted?

@msfjarvis
Copy link
Member

Should this be re-opened since the feature was reverted?

Yep.

@msfjarvis msfjarvis reopened this May 22, 2021
@msfjarvis msfjarvis added the A-Git Area: Git label May 22, 2021
@msfjarvis msfjarvis added A-UI-UX Area: General UI/UX concerns C-feature Category: This is a feature request E-medium Effort: This requires a fair amount of work P-low Priority: low S-design Status: There's a problem here, but no obvious solution; or the solution raises other questions labels May 22, 2021
@msfjarvis msfjarvis modified the milestones: v1.13.0, v2.0.0 May 22, 2021
@msfjarvis msfjarvis assigned msfjarvis and unassigned Skrilltrax Jun 14, 2021
@msfjarvis msfjarvis removed their assignment Nov 20, 2021
@msfjarvis msfjarvis added the S-help-wanted Status: This issue could use external help with implementation label Nov 20, 2021
@msfjarvis
Copy link
Member

Closing as part of issue tracker cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Git Area: Git A-UI-UX Area: General UI/UX concerns C-feature Category: This is a feature request E-medium Effort: This requires a fair amount of work P-low Priority: low S-design Status: There's a problem here, but no obvious solution; or the solution raises other questions S-help-wanted Status: This issue could use external help with implementation
Projects
None yet
Development

No branches or pull requests

10 participants