Use ImageLoaderFactory to create the singleton ImageLoader.

[colinrtwhite]

Removes ProvideImageLoader and implements ImageLoaderFactory in the Crane and Owl apps. This has a couple benefits:

• We only create one ImageLoader which is shared for every rememberImagePainter call. Each ImageLoader has its own memory cache, OkHttpClient, network observer, so it's cheaper to only create one.
• ImageLoaderFactory creates the ImageLoader lazily the first time rememberImagePainter is called.
• LocalImageLoader provides ImageLoader(context) sets LocalImageLoader.current for any child composables, however it doesn't set the singleton ImageLoader in the Coil object. If you call LocalContext.current.imageLoader elsewhere in the app, it'll return the singleton ImageLoader and not the value set in LocalImageLoader. Maybe there's a better way for Coil to handle this (open to suggestions!)...

[nickbutcher]

Thanks for the improvment! Please can we revert the AGP change, other than that LGTM.

[colinrtwhite]

@nickbutcher Thanks for the quick review! Updated based on the feedback.

[nickbutcher]

Thanks for the changes!

[nickbutcher]

Ahh, looks like this needs a gradlew spotlessApply please.

[colinrtwhite]

@nickbutcher Updated

[nickbutcher]

Thanks for the contribution!

[ColtonIdle]

@colinrtwhite I have a question about the implementation here. I currently have coil working as it was in this repo (before you made this PR. I basically shamelessly copy pasted what was here 😄 ) but I was using it in a specific compose-only module.

The goal of this module is that everything is self contained, and so now with your changes I don't actually know where I would put

override fun newImageLoader(): ImageLoader {
        return ImageLoader.Builder(this).componentRegistry { add(MyInterceptor) }.build()
    }

as I don't have an Application class. Any tips?

[colinrtwhite]

@ColtonIdle You can use Coil.setImageLoader; check out the docs here.

[ColtonIdle]

@colinrtwhite gotta be honest. Not sure where I would end up calling that setImageLoader method since my module is just filled with composables.

I have a ImageWithUrl that just wraps a Coil image. i.e.

@Composable
fun ImageWithUrl(
    imageUrl: String,
    modifier: Modifier = Modifier,
) {

I will try to play around with this a bit more as I'm probably going a bit off topic at this point.

[ColtonIdle]

For anyone following along... I ended up going this route with the guidance of @colinrtwhite

@Composable
fun ImageWithUrl(
    imageUrl: String,
) {
    Box(modifier) {
        Image(
            painter =
                rememberImagePainter(
                    data = imageUrl,
                    builder = { crossfade(true) },
                    imageLoader = getImageLoader(LocalContext.current),
                ),
            contentDescription = null)
    }
}
private var imageLoader: ImageLoader? = null
@Synchronized
private fun getImageLoader(context: Context): ImageLoader {
    imageLoader?.let {
        return it
    }
    return ImageLoader.Builder(context)
        .componentRegistry { add(MyInterceptor) }
        .build()
        .also { imageLoader = it }
}