Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Make TASKSTATS require root access

Ok, this isn't optimal, since it means that 'iotop' needs admin
capabilities, and we may have to work on this some more.  But at the
same time it is very much not acceptable to let anybody just read
anybody elses IO statistics quite at this level.

Use of the GENL_ADMIN_PERM suggested by Johannes Berg as an alternative
to checking the capabilities by hand.

Reported-by: Vasiliy Kulikov <>
Cc: Johannes Berg <>
Acked-by: Balbir Singh <>
Signed-off-by: Linus Torvalds <>
  • Loading branch information...
1 parent b6a68a5 commit 1a51410abe7d0ee4b1d112780f46df87d3621043 @torvalds torvalds committed
Showing with 1 addition and 0 deletions.
  1. +1 −0  kernel/taskstats.c
1  kernel/taskstats.c
@@ -655,6 +655,7 @@ static struct genl_ops taskstats_ops = {
.doit = taskstats_user_cmd,
.policy = taskstats_cmd_get_policy,
+ .flags = GENL_ADMIN_PERM,
static struct genl_ops cgroupstats_ops = {

0 comments on commit 1a51410

Please sign in to comment.
Something went wrong with that request. Please try again.