-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] unchecked "prebuilt" library type #1559
Comments
This is exactly what I proposed few years ago, isn't it? |
We discussed it here: #676 (comment) (Apparently I'd subconsciously remembered that because I even picked the same name despite not remembering it) This is forked from the other bug because the other bug was pushing hard for completely removing the validation, which we will not be doing. |
https://android-review.googlesource.com/c/platform/ndk/+/1833066 does this. I opted for |
In my humble opinion, this is good enough, but preferably AGP should be taught to recognize the case when this is required to resolve inter-module dependencies in a multi-module Android project, and set the flag for you. |
In practice no one will ever need to set that manually. Prefab will do it for you. The only reason anyone would ever need to use it explicitly would be rolling their own inter-module dependencies, which there isn't much reason to do. |
Similar to #676
The fix for https://issuetracker.google.com/120166563 is going to require the ability to import modules that are not owned by ndk-build but also are not yet present on disk (have missing "sources"), since Android Studio needs to be able to run ndk-build in a "configure" mode even though ndk-build has no such mode.
We can fake this well enough by adding a new library type that behaves identically to
PREBUILT_*
but without the safety net. This wayPREBUILT_*
can still help by failing-fast but prefab can generate more permissive build scripts that fail late.Open to ideas on the name, but I was thinking
EXTERNALLY_BUILT_SHARED_LIBRARY
.The text was updated successfully, but these errors were encountered: