The benchmark setup with release target is unrealistic

[yschimke]

Seems like useful sample to show both benchmark and release targets.

[mlykotom]

Could you provide more info about the problem you have?

[yschimke]

No problem, just a suggestion for the sample.

In the benchmark sample, the build setup uses a release target, which as a sample probably isn't something we would advise developers to follow.

https://github.com/android/performance-samples/blob/main/BenchmarkSample/benchmark/build.gradle

The ui module doesn't define any build variants, so presumably just has debug and release.

[yschimke]

@mlykotom apologies for the terrible bug report, I keep forgetting the context I have in my head when I drop a quick bug.

[ChrisCraik]

the build setup uses a release target, which as a sample probably isn't something we would advise developers to follow.

Why do you say this isn't something to advise? Benchmarks are in their own separate module, so it's not necessary to create a new buildType, separate from release. Nothing should ever take a dependency on a release library module that's only used for tests.

For macrobenchmark, what you're saying is true, which is why we recently changed it to use a separate benchmark build type, since it interacts with the app module. Now both match the Studio module template behavior in Bumblebee - release for the (micro)benchmark module, benchmark for the macrobench module.

[yschimke]

Thanks, I'll close then.