Update CircleCI image to use Android API 29 #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiembo
requested review from
florina-muntenescu,
keyboardsurfer,
manuelvicnt and
nickbutcher
|
Looks like failing on a (new?) lint check? |
nickbutcher
approved these changes
Nov 13, 2019
|
@tiembo is this something can can be merged? |
|
I think this is handled by #790 – close? |
|
Superseded by #790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Update the Circle CI config file to run the build and tests on an image with Android API level 29.
💡 Motivation and Context
Updating the CI files allows us to test API 29 features in CI.
💚 How did you test it?
Circle CI
📝 Checklist
./gradlew spotlessApplybefore submitting the PR🔮 Next steps
Update build.gradle with API 29 changes.
📸 Screenshots / GIFs
N/A