Use springs for RecyclerView.ItemAnimator #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbutcher
requested review from
keyboardsurfer,
florina-muntenescu,
manuelvicnt,
pfmaggi and
tiembo
| if (springAnim == null) { | ||
| springAnim = SpringAnimation(this, property).apply { | ||
| spring = SpringForce().apply { | ||
| this.dampingRatio = damping |
There was a problem hiding this comment.
this can be confusing here. Consider naming the parameters.
There was a problem hiding this comment.
Actually, should probably always configure the spring damping/stiffness, even if reusing an existing SpringAnimator. Will update.
keyboardsurfer
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
This change updates
SlideInItemAnimatorwhich is the base class of all customRecyclerView.ItemAnimators, to useSpringAnimations when animating adding or moving items.馃挕 Motivation and Context
This change supports smoother, re-targetable animations. Now if an item moves to a new position while a move is already happening, it respects the velocity of the running animation, smoothly re-targeting to the new end position.
馃挌 How did you test it?
Manually
馃摑 Checklist
./gradlew spotlessApplybefore submitting the PR馃敭 Next steps
None
馃摳 Screenshots / GIFs