Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Build fails on Windows because of wrong file separators #17

Closed
2 tasks done
DeweyReed opened this issue May 19, 2023 · 2 comments · Fixed by #20
Closed
2 tasks done

[Bug]: Build fails on Windows because of wrong file separators #17

DeweyReed opened this issue May 19, 2023 · 2 comments · Fixed by #20
Assignees
Labels
bug Something isn't working

Comments

@DeweyReed
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

In which area is the issue?

General

In a specific sample?

No response

What happened?

The build fails because samples are missing, and Hilt cannot inject.

My solution is to replace / in settings.build.kts with File.separator. And then everything works as expected. I don't know if it's the correct solution. If so, I'm also happy to open a PR.

Relevant logcat output

platform-samples\app\build\generated\hilt\component_sources\debug\com\example\platform\app\MainApp_HiltComponents.java:133: error: [Dagger/MissingBinding] java.util.Set<com.google.android.catalog.framework.base.CatalogSample> cannot be provided without an @Provides-annotated method.
  public abstract static class SingletonC implements MainApp_GeneratedInjector,
                         ^
      java.util.Set<com.google.android.catalog.framework.base.CatalogSample> is injected at
          com.google.android.catalog.framework.ui.CatalogActivity.catalogSamples
      com.example.platform.app.MainActivity is injected at
          com.example.platform.app.MainActivity_GeneratedInjector.injectMainActivity(com.example.platform.app.MainActivity) [com.example.platform.app.MainApp_HiltComponents.SingletonC �� com.example.platform.app.MainApp_HiltComponents.ActivityRetainedC �� com.example.platform.app.MainApp_HiltComponents.ActivityC]

Code of Conduct

  • I agree to follow this project's Code of Conduct
@DeweyReed DeweyReed added the bug Something isn't working label May 19, 2023
@marcelpinto marcelpinto self-assigned this May 22, 2023
@marcelpinto
Copy link
Contributor

Thanks for reporting. This indeed shouldn't be hardcoded and use the File.separator value instead.

Here is the PR #20

Could you verify it works for Windows?

@DeweyReed
Copy link
Author

It works like a charm now! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants