New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videos in Timeline are not sized properly #67

Open

calren opened this issue Apr 30, 2024 · 1 comment

Contributor

calren commented Apr 30, 2024

No description provided.

Contributor Author

calren commented Apr 30, 2024

After some investigation:

Setting the aspectRatio() is causing issues
We are not handling landscape vs portrait videos separately (I think we need to)
Not setting the aspectRatio() on the AndroidExternalSurface fixes the issue for portrait videos, but makes landscape videos look out of proportion
I think we need to draw different sized backgrounds for portrait / landscape videos, otherwise there will be a lot of blank space for landscape videos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment