Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplemented default error handling #2

Closed
albodelu opened this issue Aug 27, 2017 · 1 comment
Closed

Unimplemented default error handling #2

albodelu opened this issue Aug 27, 2017 · 1 comment

Comments

@albodelu
Copy link

albodelu commented Aug 27, 2017

Default error handling was not implemented and I was waiting for your solution.

This is a possible way to manage it. Feel free to close it but I would appreciate your opinion.

I'm not sure if I am breaking SOLID principles but show loading and error message tasks
are very related, and are repetitive tasks that I prefer to move to the base classes.

Now you can pass lambdas to the base disposable observer and add default error handling.

My app uses nullable views so I improvised a solution with lateinit a little strange for me.

Edit: I found this related article for Java:
RxJava2 and Retrofit2 Error Handling on a single place

@android10
Copy link
Owner

Thanks for the feedback @albodelu. I will close the ticket for now and will take that into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants