Support new type in bundles #1651
Conversation
…ayList<java.lang.CharSequence>
|
As we discuss in the chat room, we need to think more test cases for this pull request. (or comment on SaveInstanceStateActivityParameterizedTest) |
| @@ -183,4 +190,7 @@ | |||
|
|
|||
| @InstanceState | |||
| ParcelerBean parcelerBean; | |||
|
|
|||
| @InstanceState | |||
| SparseArray<MyGenericParcelableBean<Integer>> mySparseParcelableArray; | |||
There was a problem hiding this comment.
Let's add a comment for now.
|
I created compiling test cases for failing cases, since I don't believe my manual tests. |
|
Great. But let's add a positive test-case and check the generated code is right, then. |
|
Cool. I will add them tomorrow. |
|
There you go. |
| public class BundleSparseArrayCompileSuccessActivity extends Activity { | ||
|
|
||
| @InstanceState | ||
| SparseArray<Parcelable> mSparseArrayWithParcelable; |
There was a problem hiding this comment.
Please do not use this naming convention.
There was a problem hiding this comment.
Oops. I will fix that and another one.
|
Looks good. Can you squash the commits? |
shiraji
force-pushed
the
1577_support_new_type_in_bundles
branch
from
8ca57cd
to
43d4878
Compare
|
Squashed. |
| @Test | ||
| public void compileSuccessForBundleSparseArray() { | ||
| CompileResult result = compileFiles(BundleSparseArrayCompileSuccessActivity.class); | ||
| assertCompilationSuccessful(result); |
There was a problem hiding this comment.
Sorry, i think i was not clear. Please add assertGeneratedClassContains() here to actually check the correct method call was generated.
|
Nice. Please squash the last commit and this is can be merged. |
shiraji
force-pushed
the
1577_support_new_type_in_bundles
branch
from
771371e
to
78ed909
Compare
|
Squashed! |
Support new type in bundles
|
Great job, thanks! |
|
NP! Thanks for your help! |
see #1577