Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Add maven wrapper for the library as well as for the maven example #1906

Merged
merged 3 commits into from Nov 24, 2016

Conversation

dodgex
Copy link
Member

@dodgex dodgex commented Nov 23, 2016

see #1894

@dodgex
Copy link
Member Author

dodgex commented Nov 23, 2016

I think we should not merge until we know what happened with #1905

@dodgex
Copy link
Member Author

dodgex commented Nov 24, 2016

[WARNING] Unknown file extension: /home/travis/build/androidannotations/androidannotations/AndroidAnnotations/mvnw
[WARNING] Missing header in: /home/travis/build/androidannotations/androidannotations/AndroidAnnotations/.mvn/wrapper/maven-wrapper.properties
[WARNING] Missing header in: /home/travis/build/androidannotations/androidannotations/AndroidAnnotations/mvnw.cmd

@WonderCsabo I think we should not add copyright headers here but instead see if we can tell the license check to ignore those files?

@WonderCsabo
Copy link
Member

You are right. Please add these files to license check exclude list (it it easy).

Another thing: make sure the unix mnw files are committed to the repo with executable rights.

@dodgex
Copy link
Member Author

dodgex commented Nov 24, 2016

You are right... mvnw shoud have +x. Any chance to do it from windows or do i need to checkout this branch on a linux system?

Will check this evening

@WonderCsabo
Copy link
Member

I think you have to use a linux system for this.

@dodgex
Copy link
Member Author

dodgex commented Nov 24, 2016

Looks like it is possible from windows too: http://blog.lesc.se/2011/11/how-to-change-file-premissions-in-git.html

@WonderCsabo
Copy link
Member

Cool. Just make sure it is committed with the correct permissions.

Copy link
Member

@WonderCsabo WonderCsabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing: Travis should be modified to use the wrapper command instead of calling the pre-installed Maven binary.

- mvn -f AndroidAnnotations/pom.xml install -P travis
- mvn -f examples/maven/pom.xml install
- cd $TRAVIS_BUILD_DIR/AndroidAnnotations
- ./mvnw -f pom.xml install -P travis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-f pom.xml is not needed, as we are in the correct dir.

- cd $TRAVIS_BUILD_DIR/AndroidAnnotations
- ./mvnw -f pom.xml install -P travis
- cd $TRAVIS_BUILD_DIR/examples/maven
- ./mvnw -f pom.xml install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-f pom.xml is not needed, as we are in the correct dir.

- ./examples/gradle/gradlew assembleDebug --build-file examples/gradle/build.gradle

after_success:
- if [[ $TRAVIS_REPO_SLUG == 'androidannotations/androidannotations' && $TRAVIS_BRANCH == 'develop' && $TRAVIS_PULL_REQUEST == 'false' && $TRAVIS_JDK_VERSION == 'oraclejdk7' ]]; then mvn -f AndroidAnnotations/pom.xml -DskipTests -Dquiet -s settings.xml deploy ; fi
- if [[ $TRAVIS_REPO_SLUG == 'androidannotations/androidannotations' && $TRAVIS_BRANCH == 'develop' && $TRAVIS_PULL_REQUEST == 'false' && $TRAVIS_JDK_VERSION == 'oraclejdk7' ]]; then cd $TRAVIS_BUILD_DIR/AndroidAnnotations && ./mvnw -f pom.xml -DskipTests -Dquiet -s settings.xml deploy ; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-f pom.xml is not needed, as we are in the correct dir.

@WonderCsabo WonderCsabo merged commit cffcf57 into androidannotations:develop Nov 24, 2016
@dodgex dodgex deleted the 1894_add_maven_wrapper branch November 24, 2016 22:11
@WonderCsabo WonderCsabo added this to the 4.2 milestone Nov 24, 2016
@WonderCsabo
Copy link
Member

@dodgex pls update the dev instructons on the wiki.

@dodgex
Copy link
Member Author

dodgex commented Nov 24, 2016

Updated all usages of mvn with ./mvnw in wiki

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants