Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Remove try/catch block on @Background/@UIThread methods #682

Merged

Conversation

tbruyelle
Copy link
Contributor

Related to issue #646 and add fix for PR #677

Because the exception is now propagated, there is no need of catching
it.

Generated code :

    @Override
    public void backgroundThrowException() {
        BackgroundExecutor.execute(new BackgroundExecutor.Task("", 0, "") {


            @Override
            public void execute() {
                ThreadActivity_.super.backgroundThrowException();
            }

        }
        );
    }

Notes

  • The surroundWithTryCatch method is now unused, don't know if I have to remove it or not.

Because the exception is now propagated, there is no need of catching
it.
@DayS
Copy link
Contributor

DayS commented Jul 28, 2013

As catching an exception is not in the AA philosophy, I think you should remove it

@tbruyelle
Copy link
Contributor Author

done 4a6a77b

DayS added a commit that referenced this pull request Jul 28, 2013
Remove try/catch block on @Background/@UIThread methods
@DayS DayS merged commit 0fb5ca3 into androidannotations:develop Jul 28, 2013
@DayS
Copy link
Contributor

DayS commented Jul 28, 2013

Great 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants