Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator #1

Merged
merged 1 commit into from Aug 14, 2019
Merged

Update generator #1

merged 1 commit into from Aug 14, 2019

Conversation

michalciolek
Copy link
Contributor

@michalciolek michalciolek commented Aug 13, 2019

  • add debug and release src dirs
  • make proguard-rules.pro and build.gradle as template
  • update npm

@ravidsrk
Copy link
Member

@michalciolek Great work! But you should make the changes on parent repo: https://github.com/androidstarters/kotlin-android-starter

Once you make the update the parent repo, I will just sync it using the sync script https://github.com/androidstarters/generator-kotlin-android/blob/master/generators/app/sync_template_kotlin.js

@michalciolek
Copy link
Contributor Author

@ravidsrk I did not find out this script ;D You should add some contributions note :)

@ravidsrk ravidsrk merged commit 3fc01fd into androidstarters:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants