Feature - CircularFlow by Rodrigo Dominguez #129

rodrigomartind · 2021-02-02T18:35:32Z

CircularFlow

I add a class called CircularFlow which allows us to group views with circular references.

constraint_referenced_ids : It receives id's of the views that will add the references (Eg. "view2, view3, view4,view5,view6").

circularflow_viewCenter : It receives the id of the view of the center where the views received in constraint_referenced_ids (Eg. "view1")

circularflow_angles : Receive the angles that you will assign to each view (Eg. "45,90,135,180,225")

circularflow_radiusInDP : Receive the radios in DP that you will assign to each view (Eg. "90,100,110,120,130")

How add a view at runtime?

With method addViewToCircularFlow you can add new views to CircularFlow.

 /**
 * Add a view to the CircularFlow. The referenced view need to be a child of the container parent.
 * The view also need to have its id set in order to be added.
 * The views previous need to have its radius and angle set in order to be added correctly a new view.
 * @param view
 * @param radius
 * @param angle
 * @return
 */

Eg.

findViewById<View>(R.id.view7).setOnClickListener {
            findViewById<CircularFlow>(R.id.circularFlow).addViewToCircularFlow(
                it, 140, 200F
            )
        }

Demo add view in emulator

AddViewToCircularFlow.mp4

How remove a view at runtime?

With method removeViewFromCircularFlow you can remove a view from CircularFlow.

 /**
     * Remove a given view from the CircularFlow.
     *
     * @param view
     */

Eg.

findViewById<View>(R.id.view2).setOnClickListener {
            findViewById<CircularFlow>(R.id.circularFlow).removeViewFromCircularFlow(
                it
            )
        }

Demo remove view in emulator

Demo_removeView.mp4

Demos in AS:

Grabacion.de.pantalla.2021-02-02.a.la.s.16.33.48.mov

Grabacion.de.pantalla.2021-02-02.a.la.s.16.37.50.mov

google-cla · 2021-02-02T18:35:35Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-02-02T18:36:19Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

rodrigomartind · 2021-02-02T18:36:27Z

@googlebot I consent

google-cla · 2021-02-02T18:36:41Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-02-02T18:36:42Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

rodrigomartindMeli · 2021-02-02T18:37:24Z

@googlebot I consent.

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

camaelon · 2021-02-05T00:34:15Z

...layout/constraintlayout/src/main/java/androidx/constraintlayout/widget/ConstraintHelper.java

+    /**
+     * @hide
+     */
+    protected float[] mAngles = new float[32];


those added variables should be in CircularFlow, not in ConstraintHelper (mAngles, mRadius, etc.)

camaelon · 2021-02-05T00:35:04Z

...layout/constraintlayout/src/main/java/androidx/constraintlayout/widget/ConstraintHelper.java

@@ -112,6 +138,12 @@ protected void init(AttributeSet attrs) {
                } else if (attr == R.styleable.ConstraintLayout_Layout_constraint_referenced_tags) {
                    mReferenceTags = a.getString(attr);
                    setReferenceTags(mReferenceTags);
+                } else if (attr == R.styleable.ConstraintLayout_Layout_circularflow_angles) {


Similar -- you should add that in CircularFlow

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

camaelon

looks good! if you can address the minor comments I added we can submit this. Thanks!

camaelon · 2021-02-11T04:59:08Z

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

@@ -0,0 +1,252 @@
+/*
+ * Copyright (C) 2019 The Android Open Source Project


probably want 2021 :D

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

…larFlow

camaelon · 2021-02-11T17:14:55Z

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

+                || index >= angles.length) {
+            return angles;
+        }
+        float[] anotherArray = new float[32];


er -- you probably want to size this array according to the current size of the angles array, which technically could be more than 32 no?

camaelon · 2021-02-11T17:15:06Z

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

+                || index >= radius.length) {
+            return radius;
+        }
+        int[] anotherArray = new int[32];


same comment as above

rodrigomartind · 2021-02-11T18:30:56Z

Thanks for your review Nicolas 🚀

camaelon · 2021-02-11T18:50:40Z

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

+     *
+     * @param view
+     */
+    public void removeViewFromCircularFlow(View view){


minor nit, but if there's no additional arguments, why not override removeView() ?

Refactor done ✅

...out/constraintlayout/src/main/java/androidx/constraintlayout/helper/widget/CircularFlow.java

rodrigomartindMeli added 2 commits February 2, 2021 15:28

Added CirculrFlow first demo

02654a2

Revert documentation

4a7e373

rodrigomartind marked this pull request as ready for review February 3, 2021 12:59

camaelon reviewed Feb 5, 2021

View reviewed changes

rodrigomartindMeli added 3 commits February 9, 2021 12:36

Remove logic CircularFlow from ConstraintHelper

cdf8848

Added addViewToCircularFlow to add views in CircularFlow

1fef98a

revert removeView

92493a8

camaelon requested changes Feb 11, 2021

View reviewed changes

I added a method removeViewFromCircularFlow to remove view from Circu…

b6d171f

…larFlow

rodrigomartind changed the title ~~Feature - Circular Flow by Rodrigo Dominguez~~ Feature - CircularFlow by Rodrigo Dominguez Feb 11, 2021

camaelon reviewed Feb 11, 2021

View reviewed changes

resolve array size for angles and radius

8c39e8f

camaelon reviewed Feb 11, 2021

View reviewed changes

rodrigomartindMeli added 2 commits February 11, 2021 16:27

refactoring code

2abf6c3

refactoring code

bbef569

camaelon approved these changes Feb 11, 2021

View reviewed changes

camaelon merged commit 8ed8750 into androidx:main Feb 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature - CircularFlow by Rodrigo Dominguez #129

Feature - CircularFlow by Rodrigo Dominguez #129

rodrigomartind commented Feb 2, 2021 •

edited

google-cla bot commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

rodrigomartind commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

rodrigomartindMeli commented Feb 2, 2021

camaelon Feb 5, 2021

rodrigomartind Feb 9, 2021

camaelon Feb 5, 2021

rodrigomartind Feb 9, 2021

camaelon left a comment

camaelon Feb 11, 2021

rodrigomartind Feb 11, 2021

camaelon Feb 11, 2021

rodrigomartind Feb 11, 2021

camaelon Feb 11, 2021

rodrigomartind Feb 11, 2021

rodrigomartind commented Feb 11, 2021

camaelon Feb 11, 2021

rodrigomartindMeli Feb 11, 2021

		@@ -0,0 +1,252 @@
		/*
		* Copyright (C) 2019 The Android Open Source Project

Feature - CircularFlow by Rodrigo Dominguez #129

Feature - CircularFlow by Rodrigo Dominguez #129

Conversation

rodrigomartind commented Feb 2, 2021 • edited

CircularFlow

How add a view at runtime?

Demo add view in emulator

How remove a view at runtime?

Demo remove view in emulator

Demos in AS:

google-cla bot commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

rodrigomartind commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

rodrigomartindMeli commented Feb 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

camaelon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rodrigomartind commented Feb 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rodrigomartind commented Feb 2, 2021 •

edited