Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS Iframe only track can't be played since 1.2.0.alpha01 #1150

Closed
1 task
zgzong opened this issue Mar 5, 2024 · 9 comments
Closed
1 task

HLS Iframe only track can't be played since 1.2.0.alpha01 #1150

zgzong opened this issue Mar 5, 2024 · 9 comments
Assignees

Comments

@zgzong
Copy link
Contributor

zgzong commented Mar 5, 2024

Version

Media3 1.2.0

More version details

The HLS IFrame only track can be played on r1.1.1, same track can't be played since media3 r1.2.0-alpha01.

Devices that reproduce the issue

On android mobile, tablet and STB.

Tested on mobile: pixel 7, pixel tablet. amazon fireTV 4k stb.

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

Add Iframe only track stream into demo media.exolist.json, and play the demo app to play the iframe only track.
Any version before (include) r1.1.1, can play IFrame only track.
But since r1.2.0-alpha01, the stream can't be played, and no exception to throw.

Expected result

The IFrame only track can be played.

Actual result

Segment downloaded, but nothing rendered.

Media

iframe_only_xmap.zip
iframe_only.zip
Here are two Iframe only tracks.

Bug Report

@tianyif
Copy link
Contributor

tianyif commented Mar 5, 2024

Hi @zgzong,

Thanks for reporting! I narrowed down that the difference was introduced by #419 and specifically the the commit - b553d2c (apparently this commit was made for including HLS with that change).

We will later update here on how we can provide a solution to this.

@icbaker
Copy link
Collaborator

icbaker commented Mar 6, 2024

CC @dsparano (author of #419)

The specific comment thread where we discussed HLS in the context of that PR is here: #419 (comment)

@dsparano
Copy link
Contributor

dsparano commented Mar 6, 2024

Let me take a look at this.

@dsparano
Copy link
Contributor

Sorry for the delay. I think I've got a solution for H264 which would include general cases of byterange and I-Frame only HLS streams, which I had not personally tested when on #419.
However, I think I should test with the other readers (H262, H263 and H265) as well and for them I should have some streams available soon (if anyone has some valid streams pls share), after which I should be able to open a PR.

If an interim solution is required asap, then I suggest to disable "Send a synthesised empty pusi" if mode==MODE_HLS, @icbaker please let me know.

@dsparano
Copy link
Contributor

@icbaker possible fix here https://github.com/v-novaltd/androidx-media/tree/dsparano-exo245 shall I open a PR?

@tonihei
Copy link
Collaborator

tonihei commented Mar 18, 2024

@dsparano Given the update seems to fix all reported issues, please go ahead and open the PR. We can continue any further detailed discussion in there.

@dsparano
Copy link
Contributor

@tonihei yes, I already opened this PR: #1189

@tonihei
Copy link
Collaborator

tonihei commented Mar 18, 2024

Sorry, ignore me, thanks for the PR ;)

@rohitjoins
Copy link
Contributor

Hi @zgzong,

#419 has been rolled back and the issue should be resolved now.

@androidx androidx locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants