Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new predefined matcher to check whether URL's path exactly matches another path #116

Closed
wants to merge 2 commits into from

Conversation

int02h
Copy link

@int02h int02h commented May 10, 2022

One more predefined matcher is being added to exactly compare two URL paths. Might be useful for the case when you need to distinguish paths like foo/bar/qwe and foo/bar or foo/bar/qwe and bar/qwe when startWith or endWith matchers are not helpful.

Unit tests also added to cover new matcher.

…s another path

Signed-off-by: Daniil Popov <int02h@gmail.com>
@int02h
Copy link
Author

int02h commented Jun 27, 2022

@andrzejchm could you please take a look? Also I have no access to failed check so I am unable to see what went wrong.

@andrzejchm
Copy link
Owner

hey @int02h, in order to reproduce the fail on your local machine you can simply run:

./gradlew check -PpreDexLibraries=false

and it will report all the errors. currently it fails on:
image

@int02h
Copy link
Author

int02h commented Jul 7, 2022

hey @int02h, in order to reproduce the fail on your local machine you can simply run:

./gradlew check -PpreDexLibraries=false

and it will report all the errors. currently it fails on: image

But this PR has nothing to do with those dependencies. Is it okay to update them in this PR? Maybe it should be done separately?

@andrzejchm
Copy link
Owner

you're right, unfortunately I don't have much time recently to take care of this project so if you feel like updating those is not a hassle I'd be very grateful if you update them, even as part of this PR

Signed-off-by: Daniil Popov <int02h@gmail.com>
@int02h
Copy link
Author

int02h commented Dec 1, 2022

I am sorry. I don't have much time to investigate why check keeps failing on my machine. So I am closing this PR.

@int02h int02h closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants