Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Normalize line in the lightmapper code #20

Open
noisecrime opened this issue May 5, 2022 · 0 comments
Open

Duplicate Normalize line in the lightmapper code #20

noisecrime opened this issue May 5, 2022 · 0 comments

Comments

@noisecrime
Copy link

Hi,

Been looking through the code and came across this in lightmapper.h

569: ctx->meshPosition.sample.direction = lm_normalize3(lm_add3(n0, lm_add3(lm_scale3(nv2, uv.x), lm_scale3(nv1, uv.y))));
570: ctx->meshPosition.sample.direction = lm_normalize3(ctx->meshPosition.sample.direction);

Unless I'm reading this wrong it looks to me like a typo as direction is being normalized twice.
So I imagine line 570 can just be removed or commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant