forked from palantir/tslint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
noUnusedVariableRule.ts
388 lines (341 loc) · 14.8 KB
/
noUnusedVariableRule.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
/**
* @license
* Copyright 2014 Palantir Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import * as utils from "tsutils";
import * as ts from "typescript";
import * as Lint from "../index";
const OPTION_CHECK_PARAMETERS = "check-parameters";
const OPTION_IGNORE_PATTERN = "ignore-pattern";
export class Rule extends Lint.Rules.TypedRule {
/* tslint:disable:object-literal-sort-keys */
public static metadata: Lint.IRuleMetadata = {
ruleName: "no-unused-variable",
description: Lint.Utils.dedent`Disallows unused imports, variables, functions and
private class members. Similar to tsc's --noUnusedParameters and --noUnusedLocals
options, but does not interrupt code compilation.`,
hasFix: true,
optionsDescription: Lint.Utils.dedent`
Three optional arguments may be optionally provided:
* \`"check-parameters"\` disallows unused function and constructor parameters.
* NOTE: this option is experimental and does not work with classes
that use abstract method declarations, among other things.
* \`{"ignore-pattern": "pattern"}\` where pattern is a case-sensitive regexp.
Variable names that match the pattern will be ignored.`,
options: {
type: "array",
items: {
oneOf: [{
type: "string",
enum: ["check-parameters"],
}, {
type: "object",
properties: {
"ignore-pattern": {type: "string"},
},
additionalProperties: false,
}],
},
minLength: 0,
maxLength: 3,
},
optionExamples: [true, [true, {"ignore-pattern": "^_"}]],
type: "functionality",
typescriptOnly: true,
requiresTypeInfo: true,
};
/* tslint:enable:object-literal-sort-keys */
public applyWithProgram(sourceFile: ts.SourceFile, program: ts.Program): Lint.RuleFailure[] {
const x = program.getCompilerOptions();
if (x.noUnusedLocals === true && x.noUnusedParameters === true) {
console.warn("WARNING: 'no-unused-variable' lint rule does not need to be set if " +
"the 'no-unused-locals' and 'no-unused-parameters' compiler options are enabled.");
}
return this.applyWithFunction(sourceFile, (ctx) => walk(ctx, program, parseOptions(this.ruleArguments)));
}
}
interface Options {
checkParameters: boolean;
ignorePattern: RegExp | undefined;
}
function parseOptions(options: any[]): Options {
const checkParameters = options.indexOf(OPTION_CHECK_PARAMETERS) !== -1;
let ignorePattern: RegExp | undefined;
for (const o of options) {
if (typeof o === "object") {
// tslint:disable-next-line no-unsafe-any
const ignore = o[OPTION_IGNORE_PATTERN] as string | null | undefined;
if (ignore != null) {
ignorePattern = new RegExp(ignore);
break;
}
}
}
return { checkParameters, ignorePattern };
}
function walk(ctx: Lint.WalkContext<void>, program: ts.Program, { checkParameters, ignorePattern }: Options): void {
const { sourceFile } = ctx;
const unusedCheckedProgram = getUnusedCheckedProgram(program, checkParameters);
const diagnostics = ts.getPreEmitDiagnostics(unusedCheckedProgram, sourceFile);
const checker = unusedCheckedProgram.getTypeChecker(); // Doesn't matter which program is used for this.
// If all specifiers in an import are unused, we elide the entire import.
const importSpecifierFailures = new Map<ts.Identifier, string>();
for (const diag of diagnostics) {
const kind = getUnusedDiagnostic(diag);
if (kind === undefined) {
continue;
}
const failure = ts.flattenDiagnosticMessageText(diag.messageText, "\n");
if (kind === UnusedKind.VARIABLE_OR_PARAMETER) {
const importName = findImport(diag.start, sourceFile);
if (importName !== undefined) {
if (isImportUsed(importName, sourceFile, checker)) {
continue;
}
if (importSpecifierFailures.has(importName)) {
throw new Error("Should not get 2 errors for the same import.");
}
importSpecifierFailures.set(importName, failure);
continue;
}
}
if (ignorePattern !== undefined) {
const varName = /'(.*)'/.exec(failure)![1];
if (ignorePattern.test(varName)) {
continue;
}
}
ctx.addFailureAt(diag.start, diag.length, failure);
}
if (importSpecifierFailures.size !== 0) {
addImportSpecifierFailures(ctx, importSpecifierFailures, sourceFile);
}
}
/**
* Handle import-specifier failures separately.
* - If all of the import specifiers in an import are unused, add a combined failure for them all.
* - Unused imports are fixable.
*/
function addImportSpecifierFailures(ctx: Lint.WalkContext<void>, failures: Map<ts.Identifier, string>, sourceFile: ts.SourceFile) {
forEachImport(sourceFile, (importNode) => {
if (importNode.kind === ts.SyntaxKind.ImportEqualsDeclaration) {
tryRemoveAll(importNode.name);
return;
}
if (importNode.importClause === undefined) {
// Error node
return;
}
const { name: defaultName, namedBindings } = importNode.importClause;
if (namedBindings !== undefined && namedBindings.kind === ts.SyntaxKind.NamespaceImport) {
tryRemoveAll(namedBindings.name);
return;
}
const allNamedBindingsAreFailures = namedBindings === undefined || namedBindings.elements.every((e) => failures.has(e.name));
if (namedBindings !== undefined && allNamedBindingsAreFailures) {
for (const e of namedBindings.elements) {
failures.delete(e.name);
}
}
if ((defaultName === undefined || failures.has(defaultName)) && allNamedBindingsAreFailures) {
if (defaultName !== undefined) { failures.delete(defaultName); }
removeAll(importNode, "All imports are unused.");
return;
}
if (defaultName !== undefined) {
const failure = tryDelete(defaultName);
if (failure !== undefined) {
const start = defaultName.getStart();
const end = namedBindings !== undefined ? namedBindings.getStart() : importNode.moduleSpecifier.getStart();
const fix = Lint.Replacement.deleteFromTo(start, end);
ctx.addFailureAtNode(defaultName, failure, fix);
}
}
if (namedBindings !== undefined) {
if (allNamedBindingsAreFailures) {
const start = defaultName !== undefined ? defaultName.getEnd() : namedBindings.getStart();
const fix = Lint.Replacement.deleteFromTo(start, namedBindings.getEnd());
const failure = "All named bindings are unused.";
ctx.addFailureAtNode(namedBindings, failure, fix);
} else {
const { elements } = namedBindings;
for (let i = 0; i < elements.length; i++) {
const element = elements[i];
const failure = tryDelete(element.name);
if (failure === undefined) {
continue;
}
const prevElement = elements[i - 1];
const nextElement = elements[i + 1];
const start = prevElement !== undefined ? prevElement.getEnd() : element.getStart();
const end = nextElement !== undefined && prevElement == undefined ? nextElement.getStart() : element.getEnd();
const fix = Lint.Replacement.deleteFromTo(start, end);
ctx.addFailureAtNode(element.name, failure, fix);
}
}
}
function tryRemoveAll(name: ts.Identifier): void {
const failure = tryDelete(name);
if (failure !== undefined) {
removeAll(name, failure);
}
}
function removeAll(errorNode: ts.Node, failure: string): void {
const fix = Lint.Replacement.deleteFromTo(importNode.getStart(), importNode.getEnd());
ctx.addFailureAtNode(errorNode, failure, fix);
}
});
if (failures.size !== 0) {
throw new Error("Should have revisited all import specifier failures.");
}
function tryDelete(name: ts.Identifier): string | undefined {
const failure = failures.get(name);
if (failure !== undefined) {
failures.delete(name);
return failure;
}
return undefined;
}
}
/**
* Ignore this import if it's used as an implicit type somewhere.
* Workround for https://github.com/Microsoft/TypeScript/issues/9944
*/
function isImportUsed(importSpecifier: ts.Identifier, sourceFile: ts.SourceFile, checker: ts.TypeChecker): boolean {
let symbol = checker.getSymbolAtLocation(importSpecifier);
if (symbol === undefined) {
return false;
}
symbol = checker.getAliasedSymbol(symbol);
if (!Lint.isSymbolFlagSet(symbol, ts.SymbolFlags.Type)) {
return false;
}
return ts.forEachChild(sourceFile, function cb(child): boolean {
if (isImportLike(child)) {
return false;
}
const type = getImplicitType(child, checker);
// TODO: checker.typeEquals https://github.com/Microsoft/TypeScript/issues/13502
if (type !== undefined && checker.typeToString(type) === checker.symbolToString(symbol)) {
return true;
}
return ts.forEachChild(child, cb);
});
}
function getImplicitType(node: ts.Node, checker: ts.TypeChecker): ts.Type | undefined {
if ((utils.isPropertyDeclaration(node) || utils.isVariableDeclaration(node)) && node.type === undefined) {
return checker.getTypeAtLocation(node);
} else if (utils.isSignatureDeclaration(node) && node.type === undefined) {
return checker.getSignatureFromDeclaration(node).getReturnType();
} else {
return undefined;
}
}
type ImportLike = ts.ImportDeclaration | ts.ImportEqualsDeclaration;
function isImportLike(node: ts.Node): node is ImportLike {
return node.kind === ts.SyntaxKind.ImportDeclaration || node.kind === ts.SyntaxKind.ImportEqualsDeclaration;
}
function forEachImport<T>(sourceFile: ts.SourceFile, f: (i: ImportLike) => T | undefined): T | undefined {
return ts.forEachChild(sourceFile, (child) => {
if (isImportLike(child)) {
const res = f(child);
if (res !== undefined) {
return res;
}
}
return undefined;
});
}
function findImport(pos: number, sourceFile: ts.SourceFile): ts.Identifier | undefined {
return forEachImport(sourceFile, (i) => {
if (i.kind === ts.SyntaxKind.ImportEqualsDeclaration) {
if (i.name.getStart() === pos) {
return i.name;
}
} else {
if (i.importClause === undefined) {
// Error node
return undefined;
}
const { name: defaultName, namedBindings } = i.importClause;
if (namedBindings !== undefined && namedBindings.kind === ts.SyntaxKind.NamespaceImport) {
const { name } = namedBindings;
if (name.getStart() === pos) {
return name;
}
return undefined;
}
if (defaultName !== undefined && defaultName.getStart() === pos) {
return defaultName;
} else if (namedBindings !== undefined) {
for (const { name } of namedBindings.elements) {
if (name.getStart() === pos) {
return name;
}
}
}
}
return undefined;
});
}
const enum UnusedKind {
VARIABLE_OR_PARAMETER,
PROPERTY,
}
function getUnusedDiagnostic(diag: ts.Diagnostic): UnusedKind | undefined {
switch (diag.code) {
case 6133:
return UnusedKind.VARIABLE_OR_PARAMETER; // "'{0}' is declared but never used.
case 6138:
return UnusedKind.PROPERTY; // "Property '{0}' is declared but never used."
default:
return undefined;
}
}
const programToUnusedCheckedProgram = new WeakMap<ts.Program, ts.Program>();
function getUnusedCheckedProgram(program: ts.Program, checkParameters: boolean): ts.Program {
// Assuming checkParameters will always have the same value, so only lookup by program.
let checkedProgram = programToUnusedCheckedProgram.get(program);
if (checkedProgram !== undefined) {
return checkedProgram;
}
checkedProgram = makeUnusedCheckedProgram(program, checkParameters);
programToUnusedCheckedProgram.set(program, checkedProgram);
return checkedProgram;
}
function makeUnusedCheckedProgram(program: ts.Program, checkParameters: boolean): ts.Program {
const options = { ...program.getCompilerOptions(), noUnusedLocals: true, ...(checkParameters ? { noUnusedParameters: true } : null) };
const sourceFilesByName = new Map<string, ts.SourceFile>(program.getSourceFiles().map<[string, ts.SourceFile]>((s) => [s.fileName, s]));
// tslint:disable object-literal-sort-keys
return ts.createProgram(Array.from(sourceFilesByName.keys()), options, {
fileExists: (f) => sourceFilesByName.has(f),
readFile(f) {
const s = sourceFilesByName.get(f)!;
return s.text;
},
getSourceFile: (f) => {
const s = sourceFilesByName.get(f)!;
return ts.createSourceFile(s.fileName, s.text, s.languageVersion);
},
getDefaultLibFileName: () => ts.getDefaultLibFileName(options),
writeFile: () => {}, // tslint:disable-line no-empty
getCurrentDirectory: () => "",
getDirectories: () => [],
getCanonicalFileName: (f) => f,
useCaseSensitiveFileNames: () => true,
getNewLine: () => "\n",
});
// tslint:enable object-literal-sort-keys
}