Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing cluster proposals #1

Closed
andy-iskauskas opened this issue May 10, 2022 · 1 comment
Closed

Testing cluster proposals #1

andy-iskauskas opened this issue May 10, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andy-iskauskas
Copy link
Owner

Currently, none of the 'standard' use cases in unit tests lend themselves to testing lhs_gen_cluster (called from generate_new_runs(..., cluster = TRUE). The basic SIR emulators do not differ in active variable selection enough to warrant clustering into two groups, and even if one manually changes the active variables (eg setting SIREmulators$ems$nR$actives = c(FALSE, FALSE, TRUE)) the three emulators still get put into one cluster.

The ideal would be a set of emulators that

  • Do not require large computational time to generate and run (eg, the emulators used to test bimodal emulation);
  • Admit a non-trivial clustering via active variables;
  • Have an interesting structure that would leverage the cluster generation: perhaps 4+ parameters where the split into clusters gives a good spread of cluster 1, cluster 2, and intersection variables.

This could be an artificial set of emulators, or from a relatively simple model that gives rise to this (perhaps a time-series model)

@andy-iskauskas andy-iskauskas added enhancement New feature or request good first issue Good for newcomers labels May 10, 2022
@andy-iskauskas
Copy link
Owner Author

Resolved in commit 310cd98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant